Add infrahub.tasks as built-in logger to InfrahubGenerator class
#274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e easily propagated via CTL and CI pipeline logs.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## stable #274 +/- ##
==========================================
- Coverage 70.36% 70.34% -0.03%
==========================================
Files 82 81 -1
Lines 7497 7502 +5
Branches 1389 1391 +2
==========================================
+ Hits 5275 5277 +2
- Misses 1848 1851 +3
Partials 374 374
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dgarros
approved these changes
Feb 20, 2025
dgarros
reviewed
Feb 20, 2025
dgarros
pushed a commit
that referenced
this pull request
Feb 23, 2025
…274) * Test building in logger to InfrahubGenerator class to allow logs to be easily propagated via CTL and CI pipeline logs. * Remove unused logging import. * Add changelog to describe change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few requests to implement logging within generators within the CI pipeline output.
This adds an option to pass in your own logger or default to
infrahub.tasks.I also added
init_loggingin the generator CTL command so we can take advantage of the logging on the console as well.Please let me know if there is a more optimal way, but this might be a good thing to include in a few of the classes that run within the CI pipeline.