Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required change for object templates #273

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

gmazoyer
Copy link
Contributor

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/schema/__init__.py 25.00% 4 Missing and 2 partials ⚠️
@@                 Coverage Diff                  @@
##           infrahub-develop     #273      +/-   ##
====================================================
- Coverage             70.37%   70.33%   -0.05%     
====================================================
  Files                    82       82              
  Lines                  7503     7513      +10     
  Branches               1391     1393       +2     
====================================================
+ Hits                   5280     5284       +4     
- Misses                 1849     1853       +4     
- Partials                374      376       +2     
Flag Coverage Δ
integration-tests 22.41% <0.00%> (-0.10%) ⬇️
python-3.10 45.52% <0.00%> (-0.01%) ⬇️
python-3.11 45.52% <0.00%> (-0.01%) ⬇️
python-3.12 45.52% <0.00%> (-0.01%) ⬇️
python-3.13 45.52% <0.00%> (-0.01%) ⬇️
python-3.9 45.52% <0.00%> (-0.01%) ⬇️
python-filler-3.12 23.98% <53.84%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/schema/main.py 83.79% <100.00%> (+0.32%) ⬆️
infrahub_sdk/schema/__init__.py 66.66% <25.00%> (-1.35%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to create a new branch (infrahub-next or similar) for all changes that requires the next version of Infrahub, otherwise it will block us from publishing a new release of the SDK until the next version of Infrahub has been released

@gmazoyer gmazoyer changed the base branch from stable to infrahub-develop February 18, 2025 14:15
@gmazoyer gmazoyer merged commit 984285f into infrahub-develop Feb 20, 2025
15 checks passed
@gmazoyer gmazoyer deleted the gma-20250214-support-ifc1177 branch February 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants