Fixes #5556: Feature flags failing to log correctly #5715

kkmurerwa · 2025-02-24T17:03:56Z

Explanation

Fixes #5556: Feature flags failing to log correctly

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

github-actions · 2025-02-24T18:48:19Z

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 74.55%
Coverage Analysis: FAIL ❌

Failure Cases

File	Failure Reason	Status
FeatureFlagSyncStatusToIntegerConverter.kt utility/src/main/java/org/oppia/android/util/logging/FeatureFlagSyncStatusToIntegerConverter.kt	No appropriate test file found for utility/src/main/java/org/oppia/android/util/logging/FeatureFlagSyncStatusToIntegerConverter.kt.	❌
FeatureFlagNameToIntegerConverter.kt utility/src/main/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerConverter.kt	No appropriate test file found for utility/src/main/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerConverter.kt.	❌

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
EventBundleCreator.kt utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt	74.55%	328 / 440	✅	70%

To learn more, visit the Oppia Android Code Coverage wiki page

BenHenning · 2025-02-25T17:21:37Z

utility/src/main/java/org/oppia/android/util/logging/FeatureFlagSyncStatusToIntegerConverter.kt

+    return when (syncStatus.toString()) {
+      "SYNC_STATUS_UNSPECIFIED" -> 1
+      "NOT_SYNCED_FROM_SERVER" -> 2
+      "SYNCED_FROM_SERVER" -> 3
+      else -> -1
+    }


This should just when on the enum directly since then no conversion happens (and it can be exhaustive so else can be omitted).

Also, could we maybe just use the SyncStatus's number or index field that proto generates? That is a stable integer representation of the enum.

NTS: Use syncStatus.number to get the index

BenHenning · 2025-02-25T17:25:54Z

utility/src/main/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerConverter.kt

+      ENABLE_NPS_SURVEY -> 11
+      ENABLE_ONBOARDING_FLOW_V2 -> 12
+      ENABLE_MULTIPLE_CLASSROOMS -> 13
+      else -> -1


Let's use zero to avoid negatives for the error case.

BenHenning · 2025-02-25T17:26:17Z

utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt

+        val featureFlagSyncStatuses = featureFlagsList.map {
+          featureFlagSyncStatusConverter.convertToInteger(it.flagSyncStatus)
+        }
+
        val featureFlagEnabledStates = featureFlagsList.map { it.flagEnabledState }


As discussed, this should be replaced with 1s and 0s for trues and falses.

NTS: Use syncStatus.compareTo(false)

BenHenning · 2025-02-25T17:27:33Z

utility/src/main/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerConverter.kt

+/**
+ *
+ */
+class FeatureFlagNameToIntegerConverter @Inject constructor() {


Doesn't need to be injectable and can just be an object to avoid instantiation.

Also, let's use 'NumericId' instead of 'Integer' here and below.

…ed to integers

…erized tests

github-actions · 2025-02-26T17:17:26Z

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 75.55%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
EventBundleCreator.kt utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt	74.89%	328 / 438	✅	70%
FeatureFlagNameToIntegerNameConverter.kt utility/src/main/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerNameConverter.kt	93.75%	15 / 16	✅	70%

To learn more, visit the Oppia Android Code Coverage wiki page

kkmurerwa · 2025-02-26T17:19:36Z

@adhiamboperes this is ready for another pass. PTAL

github-actions · 2025-02-27T03:28:16Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 779 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 1083 bytes (Removed)

Method count: 260308 (old), 260274 (new), 34 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6832 (old), 6820 (new), 12 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1285 (old), 1276 (new), 9 (Removed):
- id/administrator_controls_text_view (removed)
- id/developer_options_text_view (removed)
- id/numeric_input_interaction_text_view (removed)
- id/profile_chooser_language_text_view (removed)
- id/story_progress_percentage_text_view (removed)
- And 4 others
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 855 (old), 853 (new), 2 (Removed):
- string/learn (removed)
- string/selected_image_region_selection_content_description (removed)
- string/study (removed)
- string/unselected_image_region_selection_content_description (removed)
- string/lessons (added)
- And 1 other
Style: 832 (old), 831 (new), 1 (Removed):
- style/AdministratorControlsText (removed)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 791 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 2040 bytes (Removed)
Method count: 260308 (old), 260274 (new), 34 (Removed)
Resources: 6782 (old), 6770 (new), 12 (Removed)

Id: 1285 (old), 1276 (new), 9 (Removed)
String: 855 (old), 853 (new), 2 (Removed)
Style: 832 (old), 831 (new), 1 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 8 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 8 bytes (Removed)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 1 bytes (Removed)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 8 bytes (Removed)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 8 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 4 bytes (Added)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 5015 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 3583 bytes (Added)

Method count: 115790 (old), 115792 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5800 (old), 5788 (new), 12 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1231 (old), 1222 (new), 9 (Removed):
- id/administrator_controls_text_view (removed)
- id/developer_options_text_view (removed)
- id/numeric_input_interaction_text_view (removed)
- id/profile_chooser_language_text_view (removed)
- id/story_progress_percentage_text_view (removed)
- And 4 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 788 (old), 786 (new), 2 (Removed):
- string/learn (removed)
- string/selected_image_region_selection_content_description (removed)
- string/study (removed)
- string/unselected_image_region_selection_content_description (removed)
- string/lessons (added)
- And 1 other
Style: 473 (old), 472 (new), 1 (Removed):
- style/AdministratorControlsText (removed)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 5015 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 840 bytes (Added)
Method count: 115790 (old), 115792 (new), 2 (Added)
Resources: 5757 (old), 5745 (new), 12 (Removed)

Id: 1231 (old), 1222 (new), 9 (Removed)
String: 788 (old), 786 (new), 2 (Removed)
Style: 473 (old), 472 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 8 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 8 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 2 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 4 bytes (Removed)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 4919 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 3943 bytes (Added)

Method count: 115796 (old), 115798 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5800 (old), 5788 (new), 12 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1231 (old), 1222 (new), 9 (Removed):
- id/administrator_controls_text_view (removed)
- id/developer_options_text_view (removed)
- id/numeric_input_interaction_text_view (removed)
- id/profile_chooser_language_text_view (removed)
- id/story_progress_percentage_text_view (removed)
- And 4 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 788 (old), 786 (new), 2 (Removed):
- string/learn (removed)
- string/selected_image_region_selection_content_description (removed)
- string/study (removed)
- string/unselected_image_region_selection_content_description (removed)
- string/lessons (added)
- And 1 other
Style: 473 (old), 472 (new), 1 (Removed):
- style/AdministratorControlsText (removed)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 4919 bytes (Added)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 4296 bytes (Added)
Method count: 115796 (old), 115798 (new), 2 (Added)
Resources: 5757 (old), 5745 (new), 12 (Removed)

Id: 1231 (old), 1222 (new), 9 (Removed)
String: 788 (old), 786 (new), 2 (Removed)
Style: 473 (old), 472 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 8 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 8 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 2 bytes (Added)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Removed)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 4 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 5055 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 844 bytes (Added)

Method count: 115796 (old), 115798 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5800 (old), 5788 (new), 12 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1231 (old), 1222 (new), 9 (Removed):
- id/administrator_controls_text_view (removed)
- id/developer_options_text_view (removed)
- id/numeric_input_interaction_text_view (removed)
- id/profile_chooser_language_text_view (removed)
- id/story_progress_percentage_text_view (removed)
- And 4 others
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 788 (old), 786 (new), 2 (Removed):
- string/learn (removed)
- string/selected_image_region_selection_content_description (removed)
- string/study (removed)
- string/unselected_image_region_selection_content_description (removed)
- string/lessons (added)
- And 1 other
Style: 473 (old), 472 (new), 1 (Removed):
- style/AdministratorControlsText (removed)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 5055 bytes (Added)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 2265 bytes (Added)
Method count: 115796 (old), 115798 (new), 2 (Added)
Resources: 5757 (old), 5745 (new), 12 (Removed)

Id: 1231 (old), 1222 (new), 9 (Removed)
String: 788 (old), 786 (new), 2 (Removed)
Style: 473 (old), 472 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 8 bytes (Removed)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 8 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 4 bytes (Removed)

adhiamboperes

Thanks @kkmurerwa! Implementation looks good, but the PR description could benefit from a thorough write up since we havent documented the character length issues elswehere(AFAIK) and why we chose this solution. The description could also benefit from sample logs as copied over from println debug and Firebase logs.

adhiamboperes · 2025-03-04T00:49:04Z

utility/src/main/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerNameConverter.kt

+/**
+ *
+ */


Incomplete KDoc.

adhiamboperes · 2025-03-04T00:52:40Z

utility/src/main/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerNameConverter.kt

+   * @param flagName The flag name to convert.
+   * @return An integer representation of the event name.


Suggested change

* @param flagName The flag name to convert.

* @return An integer representation of the event name.

* @param flagName the string constant flag name to convert.

* @return an integer representation of the flag name.

Per last weeks discussion, we don't want to re-use the integers. We should make a note of that in the KDoc.

adhiamboperes · 2025-03-04T00:56:28Z

...ty/src/test/java/org/oppia/android/util/logging/FeatureFlagNameToIntegerNameConverterTest.kt

+    "expectedValue=13"
+  )
+  fun testConvertToIntegerName_returnsCorrectIntegerForEach() {
+    val nameInteger = converter.convertToInteger(flagName)


Maybe?

Suggested change

val nameInteger = converter.convertToInteger(flagName)

val integerName = converter.convertToInteger(flagName)

kennethmurerwa added 4 commits February 16, 2025 17:05

Fix feature flags not logging

0bf9cdf

Add type converters for the feature flags log

ddd0848

Revert unintended changes on the FeatureFlagsLogger

380f0d6

Migrate to passing SyncStatus instead of a string

087f992

adhiamboperes assigned BenHenning and adhiamboperes Feb 25, 2025

BenHenning reviewed Feb 25, 2025

View reviewed changes

adhiamboperes assigned kkmurerwa and unassigned BenHenning and adhiamboperes Feb 25, 2025

kennethmurerwa added 2 commits February 26, 2025 17:36

Improve how feature flag sync statuses and enabled states are convert…

c99441d

…ed to integers

Add tests for the FeatureFlagToIntegerNameConverter class

7261611

kkmurerwa changed the title ~~Fix feature flags not logging~~ Fixes #5556: Feature flags failing to log correctly Feb 26, 2025

kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Feb 26, 2025

Add FlagNameToIntegerNameConverterTest.kt to list of exempted paramet…

39e81bb

…erized tests

kkmurerwa marked this pull request as ready for review February 26, 2025 16:26

kkmurerwa requested review from a team as code owners February 26, 2025 16:26

kkmurerwa requested a review from BenHenning February 26, 2025 16:26

adhiamboperes requested changes Mar 4, 2025

View reviewed changes

adhiamboperes assigned kkmurerwa and unassigned adhiamboperes Mar 4, 2025

		* @param flagName The flag name to convert.
		* @return An integer representation of the event name.

	val nameInteger = converter.convertToInteger(flagName)
	val integerName = converter.convertToInteger(flagName)

Fixes #5556: Feature flags failing to log correctly #5715

Are you sure you want to change the base?

Fixes #5556: Feature flags failing to log correctly #5715

Conversation

kkmurerwa commented Feb 24, 2025 • edited Loading

Explanation

Essential Checklist

github-actions bot commented Feb 24, 2025

Coverage Report

Results

Failure Cases

Passing coverage

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkmurerwa Feb 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkmurerwa Feb 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 26, 2025

Coverage Report

Results

Passing coverage

kkmurerwa commented Feb 26, 2025

github-actions bot commented Feb 27, 2025

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

adhiamboperes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkmurerwa commented Feb 24, 2025 •

edited

Loading

kkmurerwa Feb 26, 2025 •

edited

Loading

kkmurerwa Feb 26, 2025 •

edited

Loading