Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4609 : How to enable RTL #5294

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Fix #4609 : How to enable RTL #5294

merged 6 commits into from
Jan 26, 2024

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Jan 7, 2024

Explanation

Fix #4609 : How to enable RTL

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@MohitGupta121 MohitGupta121 requested review from a team as code owners January 7, 2024 17:20
@MohitGupta121 MohitGupta121 requested review from BenHenning and removed request for BenHenning January 7, 2024 17:20
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, Thanks!

Copy link

oppiabot bot commented Jan 15, 2024

Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 15, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 15, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121! I have a suggestion but let me know what you think

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MohitGupta121!

@adhiamboperes adhiamboperes enabled auto-merge (squash) January 26, 2024 13:38
@oppiabot oppiabot bot added the PR: LGTM label Jan 26, 2024
Copy link

oppiabot bot commented Jan 26, 2024

Hi @MohitGupta121, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes merged commit 9c5e953 into oppia:develop Jan 26, 2024
25 checks passed
@MohitGupta121 MohitGupta121 deleted the rtl_wiki branch February 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Developer Video] How to enable RTL and check for issues in the app?
2 participants