Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1882:Shifted NumericInput Rules test to numberinput subpackage #1909

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Fix #1882:Shifted NumericInput Rules test to numberinput subpackage #1909

merged 2 commits into from
Sep 28, 2020

Conversation

soamOne
Copy link
Contributor

@soamOne soamOne commented Sep 25, 2020

Explanation

Fix #1882: In this PR we are shifting numeric input rules tests to a new subpackage called numberinput.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • @@[x] The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.
    @rt4914 @BenHenning

@soamOne soamOne closed this Sep 25, 2020
@soamOne soamOne reopened this Sep 25, 2020
@soamOne
Copy link
Contributor Author

soamOne commented Sep 25, 2020

@rt4914 @BenHenning PTAL

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 25, 2020

Hey @soamOne, please have a look at the domain tests. It seems like they are failing. Also, PTAL at this guide for PR submissions.

@rt4914
Copy link
Contributor

rt4914 commented Sep 26, 2020

@soamOne Thanks for creating this PR.
Couple of points to take care of:

  1. Update your number-input-package branch with latest develop. Currently this branch is behind develop.
  2. In the Description of PR, please mention details like:
Fix #1882 

In this PR we are shifting the numeric input test files to a separate test folder.

@soamOne
Copy link
Contributor Author

soamOne commented Sep 26, 2020

Hey @Sarthak2601 @rt4914 @BenHenning PTAL now.

Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @soamOne !

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 8f34df0 into oppia:develop Sep 28, 2020
@soamOne
Copy link
Contributor Author

soamOne commented Sep 28, 2020

Thanks

@soamOne soamOne deleted the number-input-package branch September 28, 2020 03:17
@BenHenning
Copy link
Member

BenHenning commented Sep 29, 2020

Thanks @soamOne.

These files ought to go under numericinput not numberinput for parity with the other package names & for consistency with the interaction name. Also, it looks like the Bazel files weren't updated which is causing a build breakage for Bazel tests. See: https://github.com/oppia/oppia-android/blob/74db288/domain/BUILD.bazel#L64.

@soamOne
Copy link
Contributor Author

soamOne commented Sep 29, 2020

@BenHenning I will look into it and fix it, thanks.

BenHenning added a commit that referenced this pull request Sep 29, 2020
@BenHenning
Copy link
Member

Also I just realized that the original package was never updated to match the new directory structure. This is actually a case where Gradle misbehaves: it (incorrectly) doesn't require directory structures to match their directory structures, but Bazel does. Given that the build isn't actually broken, I won't revert this PR, but we should prioritize fixing that since it can lead to confusion.

Thanks @soamOne!

@soamOne
Copy link
Contributor Author

soamOne commented Sep 29, 2020

Okay, so what all needs to be done now @BenHenning ?

@BenHenning
Copy link
Member

@soamOne see #1882 (comment). Does that help?

@soamOne
Copy link
Contributor Author

soamOne commented Sep 29, 2020

Yes @BenHenning, got it.
Thanks!

@soamOne
Copy link
Contributor Author

soamOne commented Sep 29, 2020

Hey @BenHenning, a couple of questions:

  1. Can org/oppia/domain be deleted now?
  2. Should I open a new pull request?

@rt4914
Copy link
Contributor

rt4914 commented Sep 29, 2020

@soamOne

  1. You just need to take latest pull from develop and checkout from that to create a new branch. That should fix the issue related to your first question once you shift the files.
  2. Yes you can create a new PR.

@soamOne
Copy link
Contributor Author

soamOne commented Sep 29, 2020

@rt4914 okay, got it.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift NumericInput Rules test to separate sub-package
4 participants