Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend some explainer/visualizer capabilities and Fix pre-release bugs #28

Merged
merged 11 commits into from
Jun 27, 2024
Merged

Extend some explainer/visualizer capabilities and Fix pre-release bugs #28

merged 11 commits into from
Jun 27, 2024
+231 −67

Conversation

negvet
Copy link
Collaborator

@negvet negvet commented Jun 20, 2024 •
edited
Loading

  • Forward output_size
  • Fix image size estimation
  • Support overlay and resize at the same time
  • Stick to hwc, TODO: consider switch to chw.
  • Use numpy to handle targets
  • Deepcopy the input model to decouple from the user's model
  • Update save method to better handle arg less call
  • Support original input image as explainer input: use it for overlay if provided.

Fix visualizer

Verified

This commit was signed with the committer’s verified signature.
gaiksaya Sayali Gaikawad
GPG key ID: 7122166060C6D718
Verified
Learn about vigilant mode
Loading
Loading status checks…
04c60b8
@negvet negvet changed the title Fix Visualizer Fix and Enhance Visualizer Jun 20, 2024
Evgeny Tsykunov added 9 commits June 24, 2024 20:20
Fix overlay dtype

Verified

This commit was signed with the committer’s verified signature.
gaiksaya Sayali Gaikawad
GPG key ID: 7122166060C6D718
Verified
Learn about vigilant mode
Loading
Loading status checks…
4e13520
Fix color order
Loading
Loading status checks…
224b8df
Support numpy
Loading
Loading status checks…
3379c7d
numpy support: better impl
Loading
Loading status checks…
c74035a
Support targets property
Loading
Loading status checks…
fa8fb95
model deepcopy
Loading
Loading status checks…
d4847cc
Update save
Loading
Loading status checks…
191fb44
Support original_input_image as explainer argument
Loading
Loading status checks…
79da41a
Fix code quality
Loading
Loading status checks…
bec30fb
@negvet negvet changed the title Fix and Enhance Visualizer Extend some explainer/visualizer capabilities and Fix pre-release bugs Jun 26, 2024
Add tests
Loading
Loading status checks…
be9d330
@negvet negvet requested a review from goodsong81 June 26, 2024 15:41
goodsong81
goodsong81 approved these changes Jun 27, 2024
View reviewed changes
Copy link

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@negvet negvet merged commit f3d22bf into openvinotoolkit:releases/1.0.0 Jun 27, 2024
4 checks passed
@goodsong81 goodsong81 added this to the 1.0.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsong81 goodsong81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@negvet @goodsong81