Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add llm-lora.ipynb notebook #2847

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Add llm-lora.ipynb notebook #2847

merged 2 commits into from
Mar 28, 2025

Conversation

sbalandi
Copy link
Contributor

@sbalandi sbalandi commented Mar 27, 2025 •
edited
Loading

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@sbalandi sbalandi requested a review from eaidova March 27, 2025 22:35
@sbalandi sbalandi force-pushed the lora branch 2 times, most recently from a697883 to ab83f49 Compare March 27, 2025 22:57
@eaidova
Copy link
Collaborator

eaidova commented Mar 28, 2025

@sbalandi generally looks good.
only 2 small things:

  1. Please update title in notebook it syas that it is Multi-LoRA image generation
  2. please avoid camel case in notebook directory and file name

@eaidova
Copy link
Collaborator

eaidova commented Mar 28, 2025

@sbalandi also please update notebook metadata with correct info:

image

@sbalandi sbalandi force-pushed the lora branch 2 times, most recently from c113a02 to 80a08b0 Compare March 28, 2025 11:36
@sbalandi sbalandi changed the title Add llm-LoRA.ipynb notebook Add llm-lora.ipynb notebook Mar 28, 2025
eaidova
eaidova reviewed Mar 28, 2025
View reviewed changes
@eaidova eaidova merged commit 57e14de into openvinotoolkit:latest Mar 28, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaidova eaidova eaidova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbalandi @eaidova