Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agentic kit: Fix issues, improve performance, and add shopping cart feature #212

Merged
merged 28 commits into from
Mar 14, 2025
Merged

Agentic kit: Fix issues, improve performance, and add shopping cart feature #212

merged 28 commits into from
Mar 14, 2025

Conversation

antoniomtz
Copy link
Contributor

@antoniomtz antoniomtz commented Feb 27, 2025 •
edited
Loading

  • Fixed issues with LLM not calling agent tools
  • Performed rigorous testing across different LLMs to evaluate behavior, response accuracy, and latency.
  • Performed rigorous testing using different system prompts.
  • UI improvements.
  • Optimized performance for faster response times with Qwen model.
  • Implemented a shopping cart feature for better user interaction.
  • Documentation changes.

agentic_llm_rag

@antoniomtz antoniomtz self-assigned this Feb 27, 2025
@antoniomtz antoniomtz added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Feb 27, 2025
@antoniomtz
Removing config files
73c3b9e 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
solve merge conflicts
0ed855b 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Adding missing requirements.txt file
a680b2d 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Changing app.py to main.py for comply with github actions
5bcf062 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Changing app.py to main.py for comply with github actions
599645a 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
remove personality arg
4a21c52 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
change default model for convert and optimize
1cd7643 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@riacheruvu
Copy link
Contributor

riacheruvu commented Mar 3, 2025 •
edited
Loading

@antoniomtz, fantastic efforts with this PR! The interface is excellently streamlined and clear to use, the agent successfully responds to key questions/scenarios using the provided tools with quick responses, and iterating back and forth in conversation, and the shopping cart feature (adding/removing items is seamless). The agent's thought process pane is really well-designed! I validated the application on a Intel Core Ultra 7 258V system with the default config. This is awesome - thank you for this contribution!

(FYI @adrianboguszewski)

adrianboguszewski
adrianboguszewski reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@adrianboguszewski adrianboguszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoniomtz great job! Please find my comments below

antoniomtz and others added 3 commits March 5, 2025 16:59
@antoniomtz
Improving documentation and public arg in main.py
cd72f88 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Address PR feedback
47ca638 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@adrianboguszewski
Merge branch 'master' into agentic-kit
643483a
@antoniomtz
fix hf_token arg
326b05e 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Merge branch 'agentic-kit' of https://github.com/openvinotoolkit/open…
0028021 
…vino_build_deploy into agentic-kit
@antoniomtz
Adding main.py wrapper for CI/CDs
92fcc62 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Rename app.py
414dc0c 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Adding device arg
466ea9d 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Add model mapping for bge models
1e1861c 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Update args in main.py
a0a7258 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
fixing main.py
cbf9da4 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Set AUTO:GPU,CPU to main.py
92667ac 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Copy link
Contributor Author

@adrianboguszewski I made some changes for the CI/CDs, I'm getting this error and not sure why. I was able to run main.py locally with no issues:

Error: Process completed with exit code 143.

@antoniomtz
Update README
4bb4705 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Update gif in README and add queue() to Gradio demo
11b3f89 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Update README
746d9d7 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
Update README
ce0a65f 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
test llama 3B for CICDs
72d3136 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@antoniomtz
update image
99c782a 
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
@adrianboguszewski adrianboguszewski merged commit 15f6714 into master Mar 14, 2025
17 checks passed
@adrianboguszewski adrianboguszewski deleted the agentic-kit branch March 14, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianboguszewski adrianboguszewski adrianboguszewski left review comments

@riacheruvu riacheruvu riacheruvu approved these changes

@AnishaUdayakumar AnishaUdayakumar Awaiting requested review from AnishaUdayakumar

Assignees

@antoniomtz antoniomtz

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoniomtz @riacheruvu @adrianboguszewski