[core] Tensor::data member preserve constness of tensor #29594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
github-actions
bot
added
category: inference
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
The compilation errors will points where cast of tensor data pointer is done wrong (programing errors: missing const) from this perspective it will break compatibility. To avoid compile errors with current data() member there is a need to introduce new member or overload data with some tag and mark current data() as deprecated or it will work as new implementation of pointer cast, but still there will be get non-const pointer to const tensors. |
olpipi
reviewed
Mar 20, 2025
| @@ -96,7 +96,7 @@ bool Transpose::evaluate(TensorVector& outputs, const TensorVector& inputs) cons | |||
| }; | |||
|
|
|||
| auto out_ptr = int4_iterator(static_cast<uint8_t*>(out.data())); | |||
| auto in_ptr = int4_iterator(static_cast<uint8_t*>(arg.data())); | |||
| auto in_ptr = int4_iterator(static_cast<uint8_t*>(const_cast<void*>(arg.data()))); | |||
There was a problem hiding this comment.
maybe add a comment to describe that data will not be changed here
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Blocked by:
Tickets: