Remove legacy ngraph builders #22709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: IE Tests
olpipi
commented
Feb 7, 2024
| } | ||
| return nodes; | ||
| } | ||
|
|
||
| std::vector<std::pair<ov::element::Type, std::vector<std::uint8_t>>> interpreterFunction( |
There was a problem hiding this comment.
To be removed in the next PR
olpipi
force-pushed
the
remove_builders
branch
from
0168036 to
26e4b8b
Compare
praasz
reviewed
Feb 7, 2024
src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/range.cpp
Outdated
Show resolved
Hide resolved
| void resize_function(std::shared_ptr<ov::Model> function, const std::vector<ov::Shape>& targetInputStaticShapes) { | ||
| auto inputs = function->inputs(); | ||
| std::map<ov::Output<ov::Node>, ov::PartialShape> shapes; | ||
| if (inputs.size() > targetInputStaticShapes.size()) { |
There was a problem hiding this comment.
As this is test code use gtest assertion ASSERT_GT() << "error message"; ?
There was a problem hiding this comment.
This is a free function not related to direct test execution. So I would not use gtest macroces.
But there is no reason to use std::runtime_error. So I changed it to OPENVINO_ASSERT
src/tests/test_utils/common_test_utils/include/common_test_utils/ov_test_utils.hpp
Show resolved
Hide resolved
vurusovs
approved these changes
Feb 8, 2024
|
is blocked by |
olpipi
force-pushed
the
remove_builders
branch
from
26e4b8b to
5b0ed8a
Compare
praasz
approved these changes
Feb 9, 2024
olpipi
force-pushed
the
remove_builders
branch
2 times, most recently
from
db98975 to
c9fb068
Compare
olpipi
force-pushed
the
remove_builders
branch
from
c9fb068 to
2bc9a00
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
### Details: - Restore src/tests/ov_helpers/ov_models/src/precomp.hpp, deleted in #22709 - Fix build with -DENABLE_FASTER_BUILD=ON key ### Tickets: - *ticket-id*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: