[GPU] Pad-12 #19083
Merged
[GPU] Pad-12 #19083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: IE Tests
okhovan
force-pushed
the
feature/pad12
branch
2 times, most recently
from
6bbf412 to
c5309de
Compare
okhovan
force-pushed
the
feature/pad12
branch
2 times, most recently
from
c44b8ea to
4a49d54
Compare
wilson-seok
reviewed
Aug 25, 2023
| float pad_value = 0.0f; | ||
| float pad_value{0.0}; | ||
| /// @brief Allow negative values in pads_begin and pad_end. | ||
| bool allow_negative_pad; |
There was a problem hiding this comment.
Is it ok without default value?
There was a problem hiding this comment.
Is it ok without default value?
It is ok since there are default value for ctor's argument.
Though for sake of code consistency indeed it is better to have default value here.
Fixed.
|
Currently CI build is broken. Please check build error and rebase if needed. |
yeonbok
approved these changes
Aug 28, 2023
|
LGTM for gpu part, but this PR contains change on common test infra. @ilyachur could you please take a look? |
|
@ilyachur Could you please review common test infra change of this PR? Thanks! |
okhovan
force-pushed
the
feature/pad12
branch
4 times, most recently
from
58c68e6 to
6b5163e
Compare
okhovan
force-pushed
the
feature/pad12
branch
from
6b5163e to
4aae63c
Compare
wilson-seok
approved these changes
Sep 12, 2023
ilyachur
approved these changes
Sep 12, 2023
yangwang201911
pushed a commit
to yangwang201911/openvino
that referenced
this pull request
Sep 13, 2023
* GPU primitive and kernel changes to support Pad-12 * Exclude Pad-12 from GPU transformations pipeline * add unit tests * add single-layet test for Pad-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket CVS-117259