Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whisper pipeline: support stateful decoder #1474
Whisper pipeline: support stateful decoder #1474
Changes from 3 commits
68d3e48
ade7313
b2df4a6
17e3ea7
806b01a
e041a33
9502d9b
6c30fa4
7600072
f870a4c
e38cf5c
acc656f
aa0f742
3728884
445ce5a
5bdd695
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilya-lavrenov @Wovchena I want to add deprecation note for this ctor. I saw
OPENVINO_DEPRECATED
macros but I think it doesn't fit here as I want to warn user at runtime.Can I add just
std::cout << "[Warning] Whisper decoder with past deprecated ..."
? Does OV have logging utilities we can reuse? Or there is a better way?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have a better way than a message in runtime