-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image processing C++ demo #2123
Image processing C++ demo #2123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super_resolution_demo should be excluded from test cases and image_processing_demo added instaed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I have for now
demos/common/cpp/models/include/models/image_processing_model.h
Outdated
Show resolved
Hide resolved
demos/common/cpp/models/include/models/image_processing_model.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add text markers on images (half-images) in case of -orig and -mixed. Something like "O" and P (Original and Processed). Otherwise it's hard to figure out the difference. Also, you may suggest one more mode - diff - show processed image and difference image ( |processed-original| ) side-by side.
Add markers and |
you need to move demo's README.md file to the root demo folder, rename description subfolder to assets, if you want to keep images separately from sources. |
please rebase to develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve merge conflicts and address build issues
16:08:31 demos/README.md: URL reference "./super_resolution_demo/cpp/README.md" target does not exist or is not a file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, just a recommendation. I don't think it is a good idea to rewrite git history all the time:
- You do it with mistakes like unresolved conflict in be7bd84
- It's easier to review what changed on github when there are no force pushes.
please resolve merge conflict |
@eizamaliev, @fzhar, ping |
Co-authored-by: Vladimir Dudnik <vladimir.dudnik@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more comments, but minor ones
Co-authored-by: Vladimir Dudnik <vladimir.dudnik@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's think on better name for trackbar (unfortunately I do not see how to avoid printing the name, seems opencv does not allow that, it will print slider vals anyway). So, instead of "Processing" which says nothing on the purpose of this trackbar, we may put something like "O | R" to correspond labels or "orignial | result" but this is too long.
@fzhar ping |
@akorobeinikov please rebase |
17:29:15 /jenkins/workspace/omz/precommit/demos_ubuntu18@3/src/demos/segmentation_demo/cpp/main.cpp:276:73: error: ‘SegmentationResult’ was not declared in this scope |
@fzhar ping-ping |
C++ demo to unify deblurring and super_resolution processing.
In the future, it may include other types of processing (colorization etc.).