Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image processing C++ demo #2123

Merged
merged 32 commits into from
Jun 7, 2021

Conversation

akorobeinikov
Copy link
Contributor

C++ demo to unify deblurring and super_resolution processing.
In the future, it may include other types of processing (colorization etc.).

Copy link
Contributor

@vladimir-dudnik vladimir-dudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super_resolution_demo should be excluded from test cases and image_processing_demo added instaed

Copy link
Collaborator

@Wovchena Wovchena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I have for now

Copy link
Contributor

@fzhar fzhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add text markers on images (half-images) in case of -orig and -mixed. Something like "O" and P (Original and Processed). Otherwise it's hard to figure out the difference. Also, you may suggest one more mode - diff - show processed image and difference image ( |processed-original| ) side-by side.

@akorobeinikov
Copy link
Contributor Author

Please add text markers on images (half-images) in case of -orig and -mixed. Something like "O" and P (Original and Processed). Otherwise it's hard to figure out the difference. Also, you may suggest one more mode - diff - show processed image and difference image ( |processed-original| ) side-by side.

Add markers and diff mode.

@vladimir-dudnik
Copy link
Contributor

you need to move demo's README.md file to the root demo folder, rename description subfolder to assets, if you want to keep images separately from sources.
If orig, mixed and diff are mutually exclusive options then it is better to have option like mode which might have these values.
Again, when orig mode is used output screem consist from both original image and only part of resulting image, which cause output screen to have too big width. When mixed mode is used, output screen is not divided equally between original and result images.

@vladimir-dudnik
Copy link
Contributor

please rebase to develop

Copy link
Collaborator

@Wovchena Wovchena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve merge conflicts and address build issues

@vladimir-dudnik
Copy link
Contributor

16:08:31 demos/README.md: URL reference "./super_resolution_demo/cpp/README.md" target does not exist or is not a file
16:08:31 demos/README.md: demos/image_processing_demo/cpp/README.md is not referenced

Copy link
Collaborator

@Wovchena Wovchena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, just a recommendation. I don't think it is a good idea to rewrite git history all the time:

  1. You do it with mistakes like unresolved conflict in be7bd84
  2. It's easier to review what changed on github when there are no force pushes.

@vladimir-dudnik
Copy link
Contributor

please resolve merge conflict

@Wovchena
Copy link
Collaborator

@eizamaliev, @fzhar, ping

Co-authored-by: Vladimir Dudnik <vladimir.dudnik@intel.com>
Copy link
Contributor

@vladimir-dudnik vladimir-dudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments, but minor ones

Aleksei and others added 2 commits June 1, 2021 11:29
Co-authored-by: Vladimir Dudnik <vladimir.dudnik@intel.com>
Copy link
Contributor

@vladimir-dudnik vladimir-dudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's think on better name for trackbar (unfortunately I do not see how to avoid printing the name, seems opencv does not allow that, it will print slider vals anyway). So, instead of "Processing" which says nothing on the purpose of this trackbar, we may put something like "O | R" to correspond labels or "orignial | result" but this is too long.

@vladimir-dudnik
Copy link
Contributor

@fzhar ping

@vladimir-dudnik
Copy link
Contributor

@akorobeinikov please rebase

@vladimir-dudnik
Copy link
Contributor

17:29:15 /jenkins/workspace/omz/precommit/demos_ubuntu18@3/src/demos/segmentation_demo/cpp/main.cpp:276:73: error: ‘SegmentationResult’ was not declared in this scope
17:29:15 cv::Mat outFrame = renderSegmentationData(result->asRef(), outputTransform);

@vladimir-dudnik
Copy link
Contributor

@fzhar ping-ping

@eaidova eaidova merged commit dd40e8e into openvinotoolkit:develop Jun 7, 2021
mpashchenkov pushed a commit to mpashchenkov/open_model_zoo that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo Issues with demo results, performance and etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants