Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAT Lora 4/N] Strip for LoRA modules #3348

Merged
merged 10 commits into from
Mar 20, 2025
Merged

[QAT Lora 4/N] Strip for LoRA modules #3348

merged 10 commits into from
Mar 20, 2025

Conversation

ljaljushkin
Copy link
Contributor

@ljaljushkin ljaljushkin commented Mar 17, 2025 •
edited
Loading

Changes

Reason for changes

  • To able IR model conversion

Related tickets

  • 159708

Tests

  • test_fq_lora_tuning
  • test_nncf_strip_lora_model

@ljaljushkin ljaljushkin requested a review from a team as a code owner March 17, 2025 18:05
@ljaljushkin ljaljushkin requested review from daniil-lyakhov and removed request for a team March 17, 2025 18:05
@github-actions github-actions bot added NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common experimental NNCF PTQ Pull requests that updates NNCF PTQ labels Mar 17, 2025
@ljaljushkin ljaljushkin mentioned this pull request Mar 17, 2025
Closed
@github-actions github-actions bot added the API Public API-impacting changes label Mar 17, 2025
daniil-lyakhov
daniil-lyakhov approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

nncf/parameters.py
@@ -119,6 +119,23 @@ class CompressionFormat(StrEnum):
FQ_LORA = "fake_quantize_with_lora"


@api(canonical_alias="nncf.StripFormat")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should appear in the nncf API docs after the merge, please check everything is shown properly after the merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will check

AlexanderDokuchaev
AlexanderDokuchaev requested changes Mar 19, 2025
View reviewed changes
@AlexanderDokuchaev AlexanderDokuchaev merged commit cd3c678 into openvinotoolkit:develop Mar 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderDokuchaev AlexanderDokuchaev AlexanderDokuchaev approved these changes

@daniil-lyakhov daniil-lyakhov daniil-lyakhov approved these changes

Assignees

@AlexanderDokuchaev AlexanderDokuchaev

Labels
API Public API-impacting changes Code Freeze experimental NNCF Common Pull request that updates NNCF Common NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljaljushkin @AlexanderDokuchaev @daniil-lyakhov