-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX] Support weight quantization for operations where weight_port_id
!= 1
#3334
Open
siddhant-0707
wants to merge
11
commits into
openvinotoolkit:develop
Choose a base branch
from
siddhant-0707:issue3206
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b8203a5
Support weight channel axes
siddhant-0707 474e6b7
Change minmax algo to support channel axes for ConvTranspose
siddhant-0707 7319f9f
add comment back algorithm.py
siddhant-0707 3308b40
add comment algorithm.py
siddhant-0707 0ee4f8b
refactor parameter names in
siddhant-0707 74f677a
use torch weight_channel_axes in torchfx
siddhant-0707 3565ba3
streamline channel axes handling
siddhant-0707 7efa675
refactor channel axes handling
siddhant-0707 e8ab53a
refactor channel axes
siddhant-0707 5bb69f7
refactor channel axes condition
siddhant-0707 3104e58
remove whitespace
siddhant-0707 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since channel axes is already being checked and handled in the
if-else
block below.channel_axes[0]
can directly be passed tochannel_idx
parameter ofget_scale_shape
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to return
channel_idx
in this function, so I think it is needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay