Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove strip #3262

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

remove strip #3262

wants to merge 1 commit into from
+2 −17

Conversation

andrey-churkin
Copy link
Contributor

Changes

  • Calling nncf.strip() is no longer required for the TF backend, as this function is now integrated into the ov.convert_model() method. Therefore, the model can be converted directly using ov.convert_model().

@andrey-churkin andrey-churkin requested a review from a team as a code owner February 7, 2025 12:31
@github-actions github-actions bot added documentation Improvements or additions to documentation NNCF TF Pull requests that updates NNCF TensorFlow labels Feb 7, 2025
alexsu52
alexsu52 requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, you should use openvino version with nncf.strip in ov.convert_model.

@alexsu52 alexsu52 self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsu52 alexsu52 alexsu52 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@alexsu52 alexsu52

Labels
documentation Improvements or additions to documentation NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrey-churkin @alexsu52