Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare workflows for trusted publishing #574

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sovrasov
Copy link
Collaborator

@sovrasov sovrasov commented Mar 18, 2025

That step is required by security team prior to the repo moving.
Pypi-related secrets were removed from the repo.

@sovrasov sovrasov force-pushed the vs/trusted_publishing branch from 7a1b299 to ff4a2e9 Compare March 18, 2025 14:56
@sovrasov sovrasov requested a review from leoll2 March 19, 2025 13:26
fi

uses: pypa/gh-action-pypi-publish@67339c736fd9354cd4f8cb0b744f2b82a74b5c70 # v1.12.3
if: ${{ secrets.PYPI_HOST == 'test.pypi.org' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on branch [leo/test-trusted-publishing](https://github.com/openvinotoolkit/geti-sdk/tree/refs/heads/leo/test-trusted-publishing), it raises the error:

Invalid workflow file: .github/workflows/build-package-test-pypi.yaml#L14
The workflow is not valid. In .github/workflows/build-package-test-pypi.yaml (Line: 14, Col: 11): Error from called workflow 427f832 (Line: 69, Col: 13): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.PYPI_HOST == 'test.pypi.org'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should replace secrets.PYPI_HOST with $PYPI_HOST

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leoll2 thanks for checking, I was slightly afraid of actual launching this script in an unfamiliar repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants