Only render routeName badge when routeName exists #723
Conversation
| @@ -37,7 +37,7 @@ export function patternToRouteFeature( | |||
| const properties = { | |||
| color: `#${route.route_color || "000080"}`, | |||
| name: routeName, | |||
| nameUpper: routeNameUpper, | |||
| nameUpper: routeName.length === 0 ? "" : routeNameUpper, | |||
There was a problem hiding this comment.
This is a WILD hack how did you figure this out???
There was a problem hiding this comment.
routeNameUpper is what generates the background box, and it defaults to "EEE" if the routeName.length is smaller than 3! This just skips it entirely.
There was a problem hiding this comment.
But you're setting a string with length 0 only when the string length is 0?
There was a problem hiding this comment.
Sorry, to clarify, nameUpper, which is what we're setting here, generates the background box. routeNameUpper will default to EEE, so setting it to an empty string removes the background box entirely
There was a problem hiding this comment.
the EEE thing is breaking me
There was a problem hiding this comment.
Oh that's right, I did that so that the box for short route numbers still looks rectangular...
| @@ -37,7 +37,7 @@ export function patternToRouteFeature( | |||
| const properties = { | |||
| color: `#${route.route_color || "000080"}`, | |||
| name: routeName, | |||
| nameUpper: routeNameUpper, | |||
| nameUpper: routeName.length === 0 ? "" : routeNameUpper, | |||
There was a problem hiding this comment.
Oh that's right, I did that so that the box for short route numbers still looks rectangular...
Small fix to only show background for transitive route name badge if we are passing a route name.