feat(base-map): Add support for i18n on map controls #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point about the strings, I've removed the ones I'm pretty sure we don't use! |
| ResetBearing: Reset bearing to north | ||
| ZoomIn: Zoom in | ||
| ZoomOut: Zoom out | ||
| ScaleControl: |
There was a problem hiding this comment.
Where does the scale control get used? I don't see a scale on most maps.
There was a problem hiding this comment.
This is in the "with optional controls" story, but we can always remove that scale from the map if it's not representative of how we use it?
Co-authored-by: Binh Dam <56846598+binh-dam-ibigroup@users.noreply.github.com>
binh-dam-ibigroup
approved these changes
Mar 8, 2024
binh-dam-ibigroup
requested changes
Mar 8, 2024
|
Thanks for the help and the French translations, @binh-dam-ibigroup! |
binh-dam-ibigroup
approved these changes
Mar 11, 2024
miles-grant-ibigroup
requested changes
Mar 12, 2024
|
@amy-corson-ibigroup Let me add partial translations as requested before merging. |
miles-grant-ibigroup
approved these changes
Mar 14, 2024
amy-corson-ibigroup
added
the
BLOCKERS
amy-corson-ibigroup
removed
the
BLOCKERS
|
@binh-dam-ibigroup @miles-grant-ibigroup translations have been provided. I'll merge today provided everything looks okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes translated strings to MapLibre to override their default map controls.