Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support new OTP geocoder agencies field #710

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Support for opentripplanner/OpenTripPlanner#5634

No localization, but I think this is fine since there are no English words and all the GTFS will be non-localized anyway

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!!

@miles-grant-ibigroup
Copy link
Collaborator Author

miles-grant-ibigroup commented Feb 9, 2024

Wait assigning this back to me. I need to add a check that only adds a space to the string if there is something present already

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts for cleanup but nothing blocking.

@miles-grant-ibigroup miles-grant-ibigroup merged commit 1123c03 into opentripplanner:master Feb 13, 2024
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the support-new-otp-geocoder-features branch February 13, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants