Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOS link #1152

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Fix TOS link #1152

merged 8 commits into from
Feb 29, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Feb 26, 2024

Description:
Fixes a broken link in Tagalog translation.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

yarn.lock Outdated
lodash.isequal "^4.5.0"
qs "^6.9.1"

"@opentripplanner/core-utils@^11.0.2", "@opentripplanner/core-utils@^11.1.3":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these core-utils be deduplicated?

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you unpin the core-utils version and try deduplicating?

@amy-corson-ibigroup amy-corson-ibigroup changed the title Fix TOS link and update Core Utils Fix TOS link Feb 29, 2024
@amy-corson-ibigroup
Copy link
Contributor Author

Core utils was updated by #1148 so this is just correcting the Tagalog link now!

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Good fix

@amy-corson-ibigroup amy-corson-ibigroup merged commit 78536f8 into dev Feb 29, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the quick-updates-feb branch February 29, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants