Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily restore debug layers to classic debug UI and change grouping of safety layers in the new one #6497

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

optionsome
Copy link
Member

Summary

Fixes debug layers in the classic debug UI temporarily because Digitransit has some instructions for people who update OSM that need to be updated to include the new debug client.

Safety layers in the new debug client are now grouped for walk and bicycle safety.

Issue

No issue

Unit tests

No tests

Documentation

Not updated

Changelog

Maybe

@optionsome optionsome added this to the 2.7 (next release) milestone Feb 27, 2025
@optionsome optionsome requested a review from a team as a code owner February 27, 2025 10:50
@optionsome optionsome added the Digitransit Test Feature is under testing in Digitransit environment(s) label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 43.24324% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (04fadbf) to head (5d1b036).
Report is 9 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...debugrastertiles/api/resource/DebugLayersList.java 0.00% 12 Missing ⚠️
...r/ext/debugrastertiles/BikeSafetyEdgeRenderer.java 0.00% 1 Missing ⚠️
...r/ext/debugrastertiles/EdgeVertexTileRenderer.java 0.00% 1 Missing ⚠️
...er/ext/debugrastertiles/ElevationEdgeRenderer.java 0.00% 1 Missing ⚠️
...xt/debugrastertiles/NoThruTrafficEdgeRenderer.java 0.00% 1 Missing ⚠️
...nner/ext/debugrastertiles/TileRendererManager.java 0.00% 1 Missing ⚠️
...grastertiles/TraversalPermissionsEdgeRenderer.java 0.00% 1 Missing ⚠️
...r/ext/debugrastertiles/WalkSafetyEdgeRenderer.java 0.00% 1 Missing ⚠️
...r/ext/debugrastertiles/WheelchairEdgeRenderer.java 0.00% 1 Missing ⚠️
...tertiles/api/resource/DebugRasterTileResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6497      +/-   ##
=============================================
- Coverage      70.20%   70.18%   -0.02%     
+ Complexity     18313    18312       -1     
=============================================
  Files           2080     2081       +1     
  Lines          77182    77205      +23     
  Branches        7831     7832       +1     
=============================================
+ Hits           54183    54184       +1     
- Misses         20230    20251      +21     
- Partials        2769     2770       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -69,4 +70,16 @@ public Response tileGet(
cc.setNoCache(false);
return Response.ok(baos.toByteArray()).type(format.toString()).cacheControl(cc).build();
}

/**
* Gets all layer names
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gets all layers, not names

@tkalvas tkalvas merged commit b552c7f into opentripplanner:dev-2.x Mar 5, 2025
6 checks passed
@tkalvas tkalvas deleted the fix-classic-debug-layers branch March 5, 2025 07:12
t2gran pushed a commit that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Digitransit Test Feature is under testing in Digitransit environment(s) Sandbox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants