-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return stoptimesForDate from the schedule if it is called with no parameter on a day when the trip does not run #6480
Open
tkalvas
wants to merge
7
commits into
opentripplanner:dev-2.x
Choose a base branch
from
HSLdevcom:issue-6475-quick-fix
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6480 +/- ##
=============================================
- Coverage 70.20% 70.18% -0.02%
+ Complexity 18313 18312 -1
=============================================
Files 2080 2082 +2
Lines 77182 77194 +12
Branches 7831 7830 -1
=============================================
- Hits 54183 54177 -6
- Misses 20230 20250 +20
+ Partials 2769 2767 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…es even if the trip does not run today. Technically wrong, but UIs rely on this, and have for a long time
…explicit parameter of today
…the corresponding case with useScheduledWhenNonRunning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Digitransit Test
Feature is under testing in Digitransit environment(s)
Regression
This feature is no longer working.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6475
Technically the solution here is wrong, but longstanding UIs (like digitransit-ui) rely on getting the scheduled timetable when running stoptimesForDate without a parameter on a wrong day.