Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency maplibre-gl to v5 #6429

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 5, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
maplibre-gl (source) 4.7.1 -> 5.1.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

maplibre/maplibre-gl-js (maplibre-gl)

v5.1.0

Compare Source

✨ Features and improvements
🐞 Bug fixes
  • Render frame synchronized again in requestAnimationFrame callback (#​4535)

v5.0.1

Compare Source

✨ Features and improvements
🐞 Bug fixes
  • Skip control button css hover effects on touch devices (#​5285)

v5.0.0

Compare Source

✨ Features and improvements
  • ~~⚠️ Changed geometry-type to identify "Multi-" features (#​4877). Use $type which has no "Multi-" support or use in expression to get the previous behavior.~~
  • ⚠️ StyleLayer's queryIntersectsFeature method parameters were moved to QueryIntersectsFeatureParams. (#​5276) Wrap the method parameters with {} to solve this
  • ⚠️ Support setting WebGL context options on map creation (#​5196). Previously supported WebGL context options like antialias, preserveDrawingBuffer and failIfMajorPerformanceCaveat must now be defined inside the canvasContextAttributes object on MapOptions.
  • ⚠️ Change the return type of on method to return a Subscription to allow for easy unsubscribe (#​5080). map.on('x').on('y') => map.on('x'); map.on('y');.
  • ⚠️ Change drag rotate behavior to be around the center of the screen (#​5074)
  • ⚠️ Return actual altitude from queryTerrainElevation + Pass non-translated matrices to custom layer on mercator map (#​3854)
  • ⚠️ Remove unminified prod build (#​4906). You'll need to use a different build.
  • Allows setting the desired WebGL version to use (#​5236). You can now use contextType inside canvasContextAttributes to choose which WebGL version to use
  • Dual-Stack WebGL Runtime with WebGL2 to WebGL1 Fallback (#​5198)
  • Add support for projection type expression as part of a refactoring of the transfrom and projection classes (#​5139)
  • Export Event class (#​5016)
  • Support Vertical Perspective projection (#​5023)
  • When clustering circles and the promoteId is set to some parameter, the promoted ID is used on non-clustered features and the cluster_id is used on clustered features. Previously the ID was undefined for non-clustered features (#​4899)
  • Support Terrain in Globe projection (#​4976)
  • Improved performance of the coveringTiles (tile culling) function for globe (#​4937)
  • Catches network fetching errors such as CORS, DNS or malformed URL as actual AJAXError to expose HTTP request details to the "error" event (https://github.com/maplibre/maplibre-gl-js/pull/4822)
  • Add setVerticalFieldOfView() to public API (#​4717)
  • Disable sky when using globe and blend it in when changing to mercator (#​4853)
  • New GlobeControl (#​4960)
  • Add support for pitch > 90 degrees (#​4717)
  • Add support for camera roll angle (#​4717)
  • Improve performance of queryRenderedFeatures by using JavaScript Sets to assess layer membership internally (#​4777)
  • Support globe mode (#​3963)
  • Merge atmosphere and sky implementation (#​3888)
  • Add option to display a realistic atmosphere when using a Globe projection (#​3888)
🐞 Bug fixes
  • ⚠️ Fix level of detail at high pitch angle by changing which tiles to load (#​3983)
  • Fix holes at the poles when terrain is used with globe (#​5232)
  • Fix geometry artifacts when globe terrain is zoomed out too much (#​5232)
  • Fix center being incorrectly constrained when using globe (#​5186)
  • Fix atmosphere improperly blending into the background (#​5235)
  • Fix parsing wrong hash location (#​5131)
  • Fix swallowing of errors (#​4532)
  • Fix erroring requests not reported on error handler (#​4613)
  • Fix children not retained when using globe (#​5271)
  • Fix symbol size increasing when looking from poles (#​5275)
  • Fix globe custom layers being supplied incorrect matrices after projection transition to mercator (#​5150)
  • Fix custom 3D models disappearing during projection transition (#​5150)
  • Fix regression in NavigationControl compass on Firefox and Safari browsers (#​5205)
  • Fix smooth mouse wheel zooming (#​5154)
  • Change drag rotate behavior to be less abrupt around the center (#​5104)
  • Fix regression in render world copies (#​5101)
  • Fix unwanted roll when motion is interrupted (#​5083)
  • Fix geometry-type filter expression results (#​5132)
  • Fix easeTo not applying padding in globe projection (#​5134)
  • Convert WebGL1 shaders to WebGL2 (#​5166)
  • Fixes line flickering problem (#​5094)
  • Fix poor performance in Chrome related to passing matrices to WebGL (#​5072)
  • Fixes scale control for globe on zoom out (#​4897)
  • Fixes cooperative gestures displaying the mobile help text when screen width is smaller than 480px on non-touch devices (#​5053)
  • Fixes incorrect cluster radius scaling in GeoJSONSource.setClusterOptions() (#​5055)
  • Improve innerHTML handling in code (#​5057))
  • Fix geometry beyond tile borders being rendered (#​4868)
  • Fix line-placed map-pitch-aligned texts being too large when viewed from some latitudes on a globe (#​4786)
  • Disabled unsupported Fog rendering, for Terrain3D on Globe (#​4963)
  • Fix issue where raster tile source won't fetch updates following request error (#​4890)
  • Fix 3D models in custom layers not being properly occluded by the globe (#​4817)
  • Fix issue where raster tiles were not rendered correctly when using globe and terrain (#​4912)
  • Fix text not being hidden behind the globe when overlap mode was set to always (#​4802)
  • Fix a single white frame being displayed when the map internally transitions from mercator to globe projection (#​4816)
  • Fix loading of RTL plugin version 0.3.0 (#​4860)
  • Fix a memory leak due to missing removal of event listener registration (#​4824)
  • Improve symbol collision performance for both mercator and globe projections (#​4778)
  • Fix bad line scaling near the poles under globe projection (#​4778)
  • Fix globe loading many tiles at an unnecessarily high zoom level when the camera is pitched (#​4778)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner February 5, 2025 10:33
@renovate renovate bot requested a review from testower February 5, 2025 10:33
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.90%. Comparing base (2ae052f) to head (1451d60).
Report is 8 commits behind head on dev-2.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6429      +/-   ##
=============================================
- Coverage      69.90%   69.90%   -0.01%     
  Complexity     18163    18163              
=============================================
  Files           2072     2072              
  Lines          77324    77324              
  Branches        7841     7841              
=============================================
- Hits           54055    54054       -1     
- Misses         20518    20519       +1     
  Partials        2751     2751              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

renovate bot commented Feb 5, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@leonardehrenfried
Copy link
Member

@testower The code actually runs but the type checker is not happy.

Screenshot From 2025-02-05 11-46-29

It seems that the type of metadata has changed to unknown. Can you help me getting this over the finish line?

@leonardehrenfried
Copy link
Member

I think I figured it out. It's now ready for review, @testower .

Copy link
Contributor

@testower testower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - well done @leonardehrenfried

@leonardehrenfried leonardehrenfried merged commit 34d50b0 into dev-2.x Feb 5, 2025
7 checks passed
@leonardehrenfried leonardehrenfried deleted the renovate/maplibre-gl-5.x branch February 5, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants