Filter flex trips by agency and route #6421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6421 +/- ##
=============================================
+ Coverage 70.18% 70.19% +0.01%
- Complexity 18308 18348 +40
=============================================
Files 2082 2085 +3
Lines 77188 77287 +99
Branches 7828 7844 +16
=============================================
+ Hits 54175 54255 +80
- Misses 20247 20253 +6
- Partials 2766 2779 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonardehrenfried
force-pushed
the
flex-filtering
branch
from
1243956 to
fd9e9ef
Compare
leonardehrenfried
force-pushed
the
flex-filtering
branch
5 times, most recently
from
63fdbe2 to
03f20e6
Compare
# Conflicts: # application/src/ext/java/org/opentripplanner/ext/flex/FlexIndex.java
Flesh out tests
leonardehrenfried
force-pushed
the
flex-filtering
branch
from
03f20e6 to
f5ac386
Compare
|
@eibakke This is now ready for review. |
eibakke
reviewed
Mar 3, 2025
application/src/ext-test/java/org/opentripplanner/ext/flex/template/ClosestTripTest.java
Outdated
Show resolved
Hide resolved
application/src/ext/java/org/opentripplanner/ext/flex/filter/FilterMapper.java
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/transit/model/filter/expr/ExpressionBuilder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/transit/model/filter/expr/NegationMatcher.java
Outdated
Show resolved
Hide resolved
| public TripRequestBuilder withAgencies(FilterValues<FeedScopedId> agencies) { | ||
| this.agencies = agencies; | ||
| public TripRequestBuilder withIncludedAgencies(Collection<FeedScopedId> agencies) { | ||
| this.includedAgencies = FilterValues.ofEmptyIsNothing("includedAgencies", agencies); |
There was a problem hiding this comment.
@eibakke This is a different behaviour to what happens in the TransmodelAPI. Let's discuss this in the meeting.
There was a problem hiding this comment.
Ah I see now. We'll have to fix the Transmodel API to handle empty and unset arguments better. Right now it is not working as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It introduces filtering of flex trips by agency and route.
To achieve this, the regular filter request is mapped to a flex-specific version of it and then the filter logic is implemented that way.
I'm not 100% sure I got the layers of abstraction correct. I would appreciate a design or pair programming session about this.
Issue
Closes #5463
Unit tests
Lots added
Documentation
Javadoc