Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM data links added to the graph build report about ambiguous levels and layers #6049

Merged

Conversation

vesameskanen
Copy link
Contributor

@vesameskanen vesameskanen commented Sep 6, 2024

Summary

OSM level and layer processing generates lots of data issue reports. Those used to be fairly useless because the report did not specify which OSM entity had the problem.

Now each reported ambiquity contains a link to the OSM item.

@vesameskanen vesameskanen requested a review from a team as a code owner September 6, 2024 09:32
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (95415dc) to head (8cedc68).
Report is 32 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
.../issues/FloorNumberUnknownGuessedFromAltitude.java 0.00% 3 Missing ⚠️
.../opentripplanner/openstreetmap/model/OSMLevel.java 25.00% 3 Missing ⚠️
...p/issues/FloorNumberUnknownAssumedGroundLevel.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6049   +/-   ##
==========================================
  Coverage      69.74%   69.74%           
- Complexity     17318    17322    +4     
==========================================
  Files           1960     1960           
  Lines          74273    74271    -2     
  Branches        7605     7605           
==========================================
+ Hits           51800    51801    +1     
+ Misses         19830    19829    -1     
+ Partials        2643     2641    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vesameskanen vesameskanen added the Improvement A functional improvement label Sep 6, 2024
@vesameskanen vesameskanen changed the title Graph build report about ambiguous OSM levels and layers is now useful OSM data links added to the graph build report about ambiguous levels and layers Sep 9, 2024
@optionsome optionsome requested a review from jtorin September 10, 2024 09:59
@vesameskanen vesameskanen merged commit 3b9f3a2 into opentripplanner:dev-2.x Sep 10, 2024
5 checks passed
@vesameskanen vesameskanen deleted the fix-floornumber-report branch September 10, 2024 12:00
t2gran pushed a commit that referenced this pull request Sep 10, 2024
@t2gran t2gran added this to the 2.6 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement A functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants