Allow NeTEx ServiceJourneyPatterns with stopUse=passthrough #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6037 +/- ##
==========================================
Coverage 69.73% 69.74%
- Complexity 17317 17319 +2
==========================================
Files 1960 1960
Lines 74268 74273 +5
Branches 7603 7605 +2
==========================================
+ Hits 51793 51799 +6
+ Misses 19832 19831 -1
Partials 2643 2643 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
added
the
NeTEx
habrahamsson-skanetrafiken
requested review from
vpaturet and
habrahamsson-skanetrafiken
Ah, this is the reason why it's only the validation that fails, not the import itself because these pass-through points also have forBoarding/alighting=false. |
vpaturet
approved these changes
Sep 4, 2024
habrahamsson-skanetrafiken
approved these changes
Sep 5, 2024
|
Related ticket: #3640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in #6036 OTP doesn't consider pass-trough stops in
ServiceJourneyPatterns. This modifies the validation slightly so that these are removed before comparing the number of links with the passing times.Issue
Closes #6036
Unit tests
Added.
I also added some builder classes which might also become useful for other tests.
Documentation
Javadoc