-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take realtime patterns into account when storing realtime vehicles #5994
Take realtime patterns into account when storing realtime vehicles #5994
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5994 +/- ##
==========================================
Coverage 69.73% 69.73%
- Complexity 17294 17297 +3
==========================================
Files 1954 1954
Lines 74163 74167 +4
Branches 7595 7595
==========================================
+ Hits 51715 51719 +4
Misses 19809 19809
Partials 2639 2639 ☔ View full report in Codecov by Sentry. |
611727b
to
e81aa53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are potential issues with using the originalTripPattern
from a realtime added trip pattern but I think so far we have kinda merged the realtime added patterns with the normal ones in API if I remember correctly so this does make sense. I think in the somewhat near future we do want to refactor the patterns a bit more so there is a pattern which makes more sense for clients to use in most cases.
Summary
When storing realtime vehicle positions by pattern the realtime added patterns are not taken into account correctly.
This PR uses the original pattern as the key for the storage map.
Unit tests
Added.
Documentation
Explained it in Javadoc.