-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group priority to direct search #5945
Add group priority to direct search #5945
Conversation
…s down This is preparing for using the service to decorate street only itineraries.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5945 +/- ##
=============================================
+ Coverage 69.45% 69.46% +0.01%
- Complexity 17070 17090 +20
=============================================
Files 1937 1942 +5
Lines 73692 73749 +57
Branches 7540 7548 +8
=============================================
+ Hits 51184 51232 +48
- Misses 19880 19889 +9
Partials 2628 2628 ☔ View full report in Codecov by Sentry. |
src/main/java/org/opentripplanner/transit/model/network/grouppriority/EntityAdapter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found a tiny spelling mistake. Otherwise this is - as always - very clean.
…riority/EntityAdapter.java Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
Summary
The transit-group-priority feature calculate a c2 value. This is currently only done in the Raptor search, not in the AStar street search. We need this in the itinerary filters to make a fare comparison. Most street-only itineraries should just have the
baseGroup
applied, but FLEX should have the value calculated based on the FLEX trip.This PR changes the transit-group-priority service so it can be used to apply the c2 value on any itinerary. The value is added, in not present, right before the itinerary filtering is performed.
Issue
This is a prerequisite for #5919
Unit tests
✅ This is mostly refactoring the code so it can be used in the RoutingWorker in addition to Rator. So there is very little new business logic.
Documentation
✅ JavaDoc is updated
Changelog
🟥 This is improving a feature developed in this release.
Bumping the serialization version id
🟥 There should no be any changes to the serialized graph.