Use enum instead of boolean for real time update semantics #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
force-pushed
the
update-semantics
branch
from
3bc9721 to
895f196
Compare
leonardehrenfried
added
Real-Time Update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5892 +/- ##
=============================================
- Coverage 69.45% 69.45% -0.01%
- Complexity 17064 17066 +2
=============================================
Files 1927 1928 +1
Lines 73578 73580 +2
Branches 7549 7550 +1
=============================================
+ Hits 51106 51107 +1
- Misses 19847 19848 +1
Partials 2625 2625 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
leonardehrenfried
force-pushed
the
update-semantics
branch
from
56b6bd5 to
716faa2
Compare
leonardehrenfried
force-pushed
the
update-semantics
branch
from
716faa2 to
95d5bc1
Compare
t2gran
previously approved these changes
Jun 7, 2024
optionsome
reviewed
Jun 11, 2024
src/ext/java/org/opentripplanner/ext/siri/updater/EstimatedTimetableSource.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/siri/updater/SiriETHttpTripUpdateSource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/updater/trip/TimetableSnapshotSource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/updater/trip/UpdateIncrementality.java
Outdated
Show resolved
Hide resolved
optionsome
reviewed
Jun 11, 2024
Comment on lines
+8
to
+18
| /** | ||
| * The update contains all available realtime information for all trips in a given feed. The | ||
| * previously stored updates must be deleted and replaced with the information from this one. | ||
| */ | ||
| FULL_DATASET, | ||
| /** | ||
| * The update contains only information for a subset of all trips. If there is information stored | ||
| * from a previous realtime update it must be kept in order to have a complete picture of all | ||
| * trips. | ||
| */ | ||
| DIFFERENTIAL, |
There was a problem hiding this comment.
Btw does SIRI itself have some similar thing? I'm just wondering since we usually tell in the javadoc what are the matching SIRI values.
There was a problem hiding this comment.
There is a little bit of code that suggests that Siri updates can either be FULL_DATASET or DIFFERENTIAL but I don't see the former being ever returned. That's a lot of words to say "I don't know".
optionsome
approved these changes
Jun 12, 2024
t2gran
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #5871 we discussed that the boolean argument indicating if a realtime update is a full or an incremental one should be replaced with an enum, which this PR does.
Issue
#4816
@vpaturet @habrahamsson-skanetrafiken Do you want to have this for SIRI as well?