Fix trip duplication in Graph Builder DSJ mapping

[vpaturet]

Summary

As detailed in #5793, querying passing times for a replaced DatedServiceJourney fails currently with a NullPointerException.

The root cause is the creation of a duplicated Trip object during graph building when resolving the reference to the ServiceJourney associated with a replaced DatedServiceJourney.
Since looking up a given Trip in a Timetable is based on object identity rather than object equality (see

OpenTripPlanner/src/main/java/org/opentripplanner/model/Timetable.java

Line 119 in d15e616

if (tt.getTrip() == trip) {

), the lookup fails and leads to a NullPointerException.

The issue can be solved by using a deduplicator when creating the Trip object during graph building.

Issue

Close #5793

Unit tests

Added unit test.

Documentation

No

Changelog

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base (0bed0f2) to head (1896c99).
Report is 10 commits behind head on dev-2.x.

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #5794   +/-   ##
==========================================
  Coverage      67.85%   67.86%           
+ Complexity     16546    16545    -1     
==========================================
  Files           1906     1906           
  Lines          72291    72292    +1     
  Branches        7444     7444           
==========================================
+ Hits           49055    49059    +4     
+ Misses         20716    20709    -7     
- Partials        2520     2524    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eibakke]

Looks fairly straightforward to me.