Improve business logic for consolidated stops

[leonardehrenfried]

Summary

During client review, we noticed that the logic for the consolidated stops are not quite as specified which is rectified with this PR.

@miles-grant-ibigroup can you test that this satisfies the requirements?

Unit tests

Adapted.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9ed5f22) 67.54% compared to head (7692ef1) 67.62%.
Report is 85 commits behind head on dev-2.x.

Files	Patch %	Lines
...opconsolidation/DecorateConsolidatedStopNames.java	80.00%	0 Missing and 1 partial ⚠️
...tion/internal/DefaultStopConsolidationService.java	94.73%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5653      +/-   ##
=============================================
+ Coverage      67.54%   67.62%   +0.08%     
- Complexity     16292    16293       +1     
=============================================
  Files           1888     1886       -2     
  Lines          71609    71549      -60     
  Branches        7405     7384      -21     
=============================================
+ Hits           48365    48382      +17     
+ Misses         20740    20662      -78     
- Partials        2504     2505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miles-grant-ibigroup]

I think this is the correct behavior

[binh-dam-ibigroup]

@leonardehrenfried Could you clarify the alternate use of primary vs secondary stops and clarify a method name, please?

[binh-dam-ibigroup]

Seems to work fine, thanks for the clarifying comments.