Apply review feedback

opentripplanner · Aug 8, 2024 · e4199f1 · e4199f1
1 parent f2ba2c8
commit e4199f1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/main/java/org/opentripplanner/routing/vehicle_parking/VehicleParking.java b/src/main/java/org/opentripplanner/routing/vehicle_parking/VehicleParking.java
@@ -97,7 +97,7 @@ public class VehicleParking implements Serializable {
   /**
    * The currently available spaces at this vehicle parking.
    */
-  private VehicleParkingSpaces availability;
+  private volatile VehicleParkingSpaces availability;
   /**
    * The vehicle parking group this parking belongs to.
    */
@@ -254,9 +254,13 @@ public boolean hasRealTimeDataForMode(
   /**
    * The only mutable method in this class: it allows to update the available parking spaces during
    * real-time updates.
+   * Since the entity is used both by writer threads (real-time updates) and reader threads
+   * (A* routing), the update process is synchronized.
    */
   public void updateAvailability(VehicleParkingSpaces vehicleParkingSpaces) {
-    this.availability = vehicleParkingSpaces;
+    synchronized (this) {
+      this.availability = vehicleParkingSpaces;
+    }
   }
 
   @Override

diff --git a/...n/java/org/opentripplanner/updater/vehicle_parking/VehicleParkingAvailabilityUpdater.java b/...n/java/org/opentripplanner/updater/vehicle_parking/VehicleParkingAvailabilityUpdater.java
@@ -79,7 +79,7 @@ public void run(Graph graph, TransitModel ignored) {
 
     private void handleUpdate(AvailabiltyUpdate update) {
       if (!parkingById.containsKey(update.vehicleParkingId())) {
-        LOG.error(
+        LOG.warn(
           "Parking with id {} does not exist. Skipping availability update.",
           update.vehicleParkingId()
         );