Merge pull request #6111 from ibi-group/escalator-geometry

Add geometry for `EscalatorEdge`
opentripplanner · Oct 4, 2024 · ce798fd · ce798fd
2 parents e78a9ca + 2eb3c19
commit ce798fd
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/main/java/org/opentripplanner/street/model/edge/EscalatorEdge.java b/src/main/java/org/opentripplanner/street/model/edge/EscalatorEdge.java
@@ -1,6 +1,8 @@
 package org.opentripplanner.street.model.edge;
 
 import javax.annotation.Nonnull;
+import org.locationtech.jts.geom.LineString;
+import org.opentripplanner.framework.geometry.GeometryUtils;
 import org.opentripplanner.framework.i18n.I18NString;
 import org.opentripplanner.framework.i18n.LocalizedString;
 import org.opentripplanner.street.model.vertex.Vertex;
@@ -36,6 +38,11 @@ public State[] traverse(State s0) {
     } else return State.empty();
   }
 
+  @Override
+  public LineString getGeometry() {
+    return GeometryUtils.makeLineString(fromv.getCoordinate(), tov.getCoordinate());
+  }
+
   @Override
   public double getDistanceMeters() {
     return length;

diff --git a/src/test/java/org/opentripplanner/street/model/edge/EscalatorEdgeTest.java b/src/test/java/org/opentripplanner/street/model/edge/EscalatorEdgeTest.java
@@ -1,5 +1,6 @@
 package org.opentripplanner.street.model.edge;
 
+import static com.google.common.truth.Truth.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.util.Locale;
@@ -42,15 +43,15 @@ void testCycling() {
     var edge = EscalatorEdge.createEscalatorEdge(from, to, 10);
     var req = StreetSearchRequest.of().withMode(StreetMode.BIKE);
     var res = edge.traverse(new State(from, req.build()));
-    assertEquals(res.length, 0);
+    assertThat(res).isEmpty();
   }
 
   @Test
   void testWheelchair() {
     var edge = EscalatorEdge.createEscalatorEdge(from, to, 10);
     var req = StreetSearchRequest.of().withMode(StreetMode.WALK).withWheelchair(true);
     var res = edge.traverse(new State(from, req.build()));
-    assertEquals(res.length, 0);
+    assertThat(res).isEmpty();
   }
 
   @Test
@@ -59,4 +60,10 @@ void name() {
     assertEquals("Rolltreppe", edge.getName().toString(Locale.GERMANY));
     assertEquals("escalator", edge.getName().toString(Locale.ENGLISH));
   }
+
+  @Test
+  void geometry() {
+    var edge = EscalatorEdge.createEscalatorEdge(from, to, 10);
+    assertThat(edge.getGeometry().getCoordinates()).isNotEmpty();
+  }
 }