Fix min width on tooltip #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents text from being hidden on narrower viewports.
|
it's possible I added the min-width to deal with the feedback options tooltips so maybe just make sure those are not too weird |
|
confirmed the radio input tooltips get a little wonky without the minimum. maybe you could just keep the minimum when this is the parent?
|
bethshook
approved these changes
Aug 26, 2024
|
Good find... for another idea, maybe I could target an |
|
I think I worked around this issue in assignments so maybe we don't need this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super low priority PR... Having a min-width on Tooltip was causing me issues with really narrow viewports, so it seems like removing it would be good? We can close this though if we'd rather target them on the consuming side or there are design concerns (not sure if we have Figma stuff for the tooltips...)