Extract BodyPortal props type and fix lint

openstax · Aug 26, 2024 · f7337d2 · f7337d2
1 parent 8db17f5
commit f7337d2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/components/BodyPortal.spec.tsx b/src/components/BodyPortal.spec.tsx
@@ -181,7 +181,7 @@ describe('BodyPortal', () => {
   });
 
   it('accepts an optional ref parameter that will be set', () => {
-    const TestPortal = ({ children }: React.PropsWithChildren<{}>) => {
+    const TestPortal = ({ children }: React.PropsWithChildren<unknown>) => {
       const ref = React.useRef<HTMLElement | null>(null);
       expect(ref.current).toBeNull();
 

diff --git a/src/components/BodyPortal.tsx b/src/components/BodyPortal.tsx
@@ -21,12 +21,16 @@ const getInsertBeforeTarget = (bodyPortalSlots: string[], slot?: string) => {
   return null;
 }
 
-export const BodyPortal = React.forwardRef<HTMLElement, React.PropsWithChildren<{
+export type BodyPortalProps = React.PropsWithChildren<{
   className?: string;
   role?: string;
   slot?: string;
   tagName?: string;
-}>>(({ children, className, role, slot, tagName }, ref) => {
+}>;
+
+export const BodyPortal = React.forwardRef<HTMLElement, BodyPortalProps>((
+  { children, className, role, slot, tagName }, ref?: React.ForwardedRef<HTMLElement>
+) => {
   const tag = tagName?.toUpperCase() ?? 'DIV';
   const internalRef = React.useRef<HTMLElement>(document.createElement(tag));
   if (internalRef.current.tagName !== tag) {