Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three rex-web tests converted to playwright #2391

Merged
merged 11 commits into from
Mar 5, 2025
Merged

three rex-web tests converted to playwright #2391

merged 11 commits into from
Mar 5, 2025

Conversation

omehes
Copy link
Contributor

@omehes omehes commented Jan 27, 2025

converting or rewriting selenium tests into playwright: https://openstax.atlassian.net/browse/CORE-775

@TomWoodward TomWoodward temporarily deployed to rex-web-playwright-xsbvwglvify January 27, 2025 20:24 Inactive
@omehes omehes self-assigned this Jan 28, 2025
@omehes omehes force-pushed the playwright branch 2 times, most recently from fd69977 to d798708 Compare February 17, 2025 18:45
@omehes omehes marked this pull request as ready for review February 27, 2025 19:47
@omehes omehes requested review from a team as code owners February 27, 2025 19:47
@omehes omehes requested review from gregfitch and Dantemss February 27, 2025 19:47
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@pytest.fixture
def abl_approved():
"""Return list of dictionaries of approved books in ABL json"""
abl_url = "https://corgi.ce.openstax.org/api/abl/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omehes omehes removed the request for review from gregfitch March 5, 2025 14:38
@Dantemss Dantemss merged commit baaa488 into main Mar 5, 2025
10 of 12 checks passed
@Dantemss Dantemss deleted the playwright branch March 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants