Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deselect pending highlight when user navigates away #2330

Merged
merged 14 commits into from
Sep 17, 2024
Merged

Deselect pending highlight when user navigates away #2330

merged 14 commits into from
Sep 17, 2024

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Aug 19, 2024 •
edited by jira bot
Loading

@RoyEJohnson RoyEJohnson requested a review from a team as a code owner August 19, 2024 22:28
@RoyEJohnson RoyEJohnson requested a review from jivey August 19, 2024 22:28
@TomWoodward TomWoodward temporarily deployed to rex-web-abort-highlight-gk8ywe August 19, 2024 22:29 Inactive
jivey
jivey requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, I noticed one small difference between this and production - alt-tabbing away from the browser and coming back closes it. Is it possible to track the window blur state and only close when it's focused?

@RoyEJohnson RoyEJohnson force-pushed the abort-highlight-selection-when-focus-moves branch from 592b2d9 to f4c9cd6 Compare August 21, 2024 14:03
@TomWoodward TomWoodward temporarily deployed to rex-web-abort-highlight-gk8ywe August 21, 2024 14:03 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-abort-highlight-gk8ywe August 21, 2024 14:25 Inactive
@RoyEJohnson
Copy link
Contributor Author

@jivey Forgot that contains is true when it's equal.

@RoyEJohnson RoyEJohnson requested a review from jivey August 21, 2024 14:25
jivey
jivey approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@TomWoodward TomWoodward temporarily deployed to rex-web-abort-highlight-gk8ywe August 21, 2024 22:26 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-abort-highlight-gk8ywe August 22, 2024 16:41 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-abort-highlight-v6zkiz September 17, 2024 16:13 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-abort-highlight-v6zkiz September 17, 2024 21:38 Inactive
@Malar-Natarajan Malar-Natarajan merged commit bb00e9b into main Sep 17, 2024
7 of 9 checks passed
@Malar-Natarajan Malar-Natarajan deleted the abort-highlight-selection-when-focus-moves branch September 17, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
in-production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RoyEJohnson @jivey @TomWoodward @staxbot @Malar-Natarajan