-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DISCO-290 Set Rex heading levels for Assignable #2269
Merged
Merged
Changes from 83 commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
74f932f
Set Rex heading levels for Assignable
Dantemss 1df43cb
Merge branch 'main' into heading-levels
Dantemss e568650
Merge branch 'main' into heading-levels
staxly[bot] 2d7af52
Merge branch 'main' into heading-levels
staxly[bot] 81a125a
Merge branch 'main' into heading-levels
staxly[bot] ca09a65
Merge branch 'main' into heading-levels
staxly[bot] 4e977b3
Merge branch 'main' into heading-levels
staxly[bot] 475864b
Merge branch 'main' into heading-levels
staxly[bot] afaf742
Merge branch 'main' into heading-levels
staxly[bot] 06a5477
Merge branch 'main' into heading-levels
staxly[bot] a76e1e6
Merge branch 'main' into heading-levels
staxly[bot] 5099bfd
Merge branch 'main' into heading-levels
staxly[bot] 4d18dbd
Merge branch 'main' into heading-levels
staxly[bot] 59c0991
Merge branch 'main' into heading-levels
staxly[bot] b84fe2e
Merge branch 'main' into heading-levels
staxly[bot] 1bcd733
Merge branch 'main' into heading-levels
staxly[bot] 141740d
Merge branch 'main' into heading-levels
staxly[bot] 7c27d0b
Merge branch 'main' into heading-levels
staxly[bot] b154dfb
Merge branch 'main' into heading-levels
staxly[bot] a5c38cf
Merge branch 'main' into heading-levels
staxly[bot] fd39318
Merge branch 'main' into heading-levels
staxly[bot] 0836f13
Merge branch 'main' into heading-levels
staxly[bot] b4248c3
Merge branch 'main' into heading-levels
staxly[bot] 923b1b3
Merge branch 'main' into heading-levels
staxly[bot] eeb8b99
Merge branch 'main' into heading-levels
staxly[bot] 75acbfc
Merge branch 'main' into heading-levels
staxly[bot] 49b2547
Merge branch 'main' into heading-levels
staxly[bot] ee54f50
Merge branch 'main' into heading-levels
staxly[bot] d499fc1
Merge branch 'main' into heading-levels
staxly[bot] 09f05b7
Merge branch 'main' into heading-levels
staxly[bot] 6efe64b
Merge branch 'main' into heading-levels
staxly[bot] e16eea2
Merge branch 'main' into heading-levels
staxly[bot] 7672f06
Merge branch 'main' into heading-levels
staxly[bot] 5b4f546
Merge branch 'main' into heading-levels
staxly[bot] 377c83b
Merge branch 'main' into heading-levels
staxly[bot] ca61a24
Merge branch 'main' into heading-levels
staxly[bot] 6719711
Merge branch 'main' into heading-levels
staxly[bot] 3247504
Merge branch 'main' into heading-levels
staxly[bot] 3d5c47b
Merge branch 'main' into heading-levels
staxly[bot] bcc6eec
Merge branch 'main' into heading-levels
staxly[bot] f76177a
Merge branch 'main' into heading-levels
staxly[bot] 55c650c
Merge branch 'main' into heading-levels
staxly[bot] 5ce8de4
Merge branch 'main' into heading-levels
staxly[bot] e9b1fda
Merge branch 'main' into heading-levels
staxly[bot] 30dde8b
Merge branch 'main' into heading-levels
staxly[bot] fb2ce2a
Merge branch 'main' into heading-levels
staxly[bot] 54b3cf1
Merge branch 'main' into heading-levels
staxly[bot] 12d4ae1
Merge branch 'main' into heading-levels
staxly[bot] 0e05376
Merge branch 'main' into heading-levels
staxly[bot] 5023a7a
Merge branch 'main' into heading-levels
staxly[bot] 35ae014
Merge branch 'main' into heading-levels
staxly[bot] b0832d9
Merge branch 'main' into heading-levels
staxly[bot] 577afb0
Merge branch 'main' into heading-levels
staxly[bot] 916cfc6
Merge branch 'main' into heading-levels
staxly[bot] 838771d
Merge branch 'main' into heading-levels
staxly[bot] 1e6b915
Merge branch 'main' into heading-levels
staxly[bot] 828c81a
Merge branch 'main' into heading-levels
staxly[bot] ae2b259
Merge branch 'main' into heading-levels
staxly[bot] 7fc97e9
Merge branch 'main' into heading-levels
staxly[bot] 34524c9
Merge branch 'main' into heading-levels
staxly[bot] e3b725a
Merge branch 'main' into heading-levels
staxly[bot] da16a64
Merge branch 'main' into heading-levels
staxly[bot] 6b7ee80
Merge branch 'main' into heading-levels
staxly[bot] 0689acd
Merge branch 'main' into heading-levels
staxly[bot] 9322923
Merge branch 'main' into heading-levels
staxly[bot] 6c76e43
Merge branch 'main' into heading-levels
staxly[bot] 5b1c53a
Merge branch 'main' into heading-levels
staxly[bot] 5f4caad
Merge branch 'main' into heading-levels
staxly[bot] 66f9a79
Merge branch 'main' into heading-levels
staxly[bot] 58160ff
Merge branch 'main' into heading-levels
staxly[bot] 026c01e
Merge branch 'main' into heading-levels
staxly[bot] afad8a7
Merge branch 'main' into heading-levels
staxly[bot] 979ac94
Merge branch 'main' into heading-levels
staxly[bot] 5b12208
Merge branch 'main' into heading-levels
9c79ef4
replace old heading tags with new
813e956
Merge branch 'heading-levels' of https://github.com/openstax/rex-web …
0f79e7f
lint fix
56e1473
update comment
49aa25e
allow heading levels to decrease
08f8da3
undo change
bc77d79
being confused by numbers
45952ed
lint fix
4fa7e72
Merge branch 'main' into heading-levels
staxly[bot] eae77ed
fix condition and add spec
2e4cb67
update spec
5025303
Merge branch 'heading-levels' of https://github.com/openstax/rex-web …
382095a
lint fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if desired topHeading level is 2, and the currentTopHeading is 3, we don't want to skip we want to bump them all up.
if they are equal we can return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, was confused on this point