update prerender to include a content manifest csv output #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jivey
approved these changes
Jul 2, 2024
script/prerender/contentManifest.ts
Outdated
|
|
||
| const quoteValue = (value?: string) => value ? `"${value.replace(/"/g, '""')}"` : '""'; | ||
|
|
||
| export const renderAndSaveContentManfiest = async( |
| : []; | ||
|
|
||
| return [ | ||
| [stripIdVersion(id), title, textTitle, book.language, ...urlParams, tocType, toc_target_type ?? ''], |
There was a problem hiding this comment.
I'm surprised the real (html) title gets used, but maybe the textTitle is used as the display value in the reports?
There was a problem hiding this comment.
Yea I doubt that the html will be used by anything but I threw it in there. the text title is intended to be used by reporting I added the context number in there for the eoc pages
script/prerender/sitemap.ts
Outdated
|
|
||
| export const sitemapPath = (pathName: string) => `/rex/sitemaps/${pathName}.xml`; | ||
| export const contentManifestPath = (pathName: string) => `/rex/manifest/${pathName}.xml`; |
jivey
requested changes
Jul 3, 2024
script/prerender/fleet.ts
Outdated
| import { SitemapPayload } from './sitemap'; | ||
| import { SitemapPayload, renderAndSaveSitemapIndex } from './sitemap'; | ||
| import { writeS3ReleaseXmlFile } from './fileUtils'; | ||
| import { renderAndSaveContentManfiest } from './contentManifest'; |
jivey
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/DISCO-23
adds a csv output of all book toc node info for use by reporting platforms to associate uuids with slugs with titles (for querying and output formatting in reporting dashboards)
also moved sitemap index output to queue generation to avoid loading all the books twice