Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trap focus in note menu #2246

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Trap focus in note menu #2246

merged 8 commits into from
Jul 18, 2024

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented May 29, 2024 •
edited by jira bot
Loading

@RoyEJohnson RoyEJohnson requested a review from a team as a code owner May 29, 2024 17:48
@RoyEJohnson RoyEJohnson requested a review from jivey May 29, 2024 17:48
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-wsijdi May 29, 2024 17:48 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-wsijdi May 29, 2024 18:00 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-wsijdi May 29, 2024 19:10 Inactive
@RoyEJohnson RoyEJohnson force-pushed the trap-focus-in-note-menu branch from 91acf39 to 0cb10d3 Compare May 29, 2024 19:11
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-wsijdi May 29, 2024 19:11 Inactive
jivey
jivey approved these changes May 30, 2024
View reviewed changes
src/app/theme.ts
export const defaultFocusOutline = `
outline: 0.1rem dotted #212121;
outline: 0.5rem auto -webkit-focus-ring-color;
outline: 0.2rem auto Highlight;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know you could do this for Firefox too -- cool!

@RoyEJohnson RoyEJohnson force-pushed the trap-focus-in-note-menu branch from 0cb10d3 to d229975 Compare May 31, 2024 20:36
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-wsijdi May 31, 2024 20:36 Inactive
@Malar-Natarajan
Copy link
Contributor

@RoyEJohnson could you please resolve the conflicts

@RoyEJohnson RoyEJohnson force-pushed the trap-focus-in-note-menu branch from d229975 to 6ba1257 Compare June 27, 2024 20:26
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-trap-focus-in-n-nxlb2t June 28, 2024 12:39 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-nxlb2t June 28, 2024 17:48 Inactive
@RoyEJohnson RoyEJohnson force-pushed the trap-focus-in-note-menu branch from 128b3ba to 674916e Compare July 1, 2024 19:38
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-nxlb2t July 1, 2024 19:38 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-nxlb2t July 2, 2024 15:50 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 17, 2024 13:40 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 17, 2024 17:26 Inactive
@RoyEJohnson RoyEJohnson force-pushed the trap-focus-in-note-menu branch from b7c2cf8 to 3750321 Compare July 17, 2024 17:27
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 17, 2024 17:27 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 17, 2024 17:33 Inactive
@RoyEJohnson
Use focus indicator on ColorIndicator, not ColorPicker
8497f23 
Adjust focus outline style
Update snapshots
@RoyEJohnson RoyEJohnson force-pushed the trap-focus-in-note-menu branch from d6dbbde to 8497f23 Compare July 17, 2024 17:36
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 17, 2024 17:36 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 17, 2024 18:59 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 18, 2024 12:50 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-trap-focus-in-n-dcmbvf July 18, 2024 15:08 Inactive
@Malar-Natarajan Malar-Natarajan merged commit 3255c0d into main Jul 18, 2024
7 of 9 checks passed
@Malar-Natarajan Malar-Natarajan deleted the trap-focus-in-note-menu branch July 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
in-production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RoyEJohnson @Malar-Natarajan @jivey @TomWoodward @staxbot