Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group checkboxes in dropdowns #2207

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Group checkboxes in dropdowns #2207

merged 9 commits into from
Jul 25, 2024

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Mar 28, 2024 •
edited by jira bot
Loading

@TomWoodward TomWoodward temporarily deployed to rex-web-make-group-for--taf02m March 28, 2024 14:42 Inactive
@RoyEJohnson RoyEJohnson force-pushed the make-group-for-dropdown-checkboxes branch from 080b49c to 46073af Compare March 28, 2024 14:57
@TomWoodward TomWoodward temporarily deployed to rex-web-make-group-for--taf02m March 28, 2024 14:57 Inactive
@RoyEJohnson RoyEJohnson marked this pull request as ready for review March 28, 2024 14:57
@RoyEJohnson RoyEJohnson requested a review from a team as a code owner March 28, 2024 14:57
@RoyEJohnson RoyEJohnson requested a review from jivey March 28, 2024 14:57
jivey
jivey approved these changes Mar 28, 2024
View reviewed changes
src/app/theme.ts Outdated
@@ -9,6 +9,18 @@ export interface ColorSet {
darkest?: string;
}

export const hiddenButAccessible = `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking but visuallyHidden could be a good name for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a visuallyHidden in Dropdown (and a contrasting visuallyShown). Since it uses height/width 0, it's also hidden from screenreaders. Probably need to rename it to fullyHidden or something. I'm not entirely clear on what the point of it is, why it's not display: none.

@TomWoodward TomWoodward temporarily deployed to rex-web-make-group-for--taf02m April 1, 2024 11:17 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-make-group-for--lch4fv May 16, 2024 18:35 Inactive
@Malar-Natarajan
Copy link
Contributor

@RoyEJohnson Could you please resolve the conflicts on this PR

@RoyEJohnson RoyEJohnson force-pushed the make-group-for-dropdown-checkboxes branch from 80e8588 to c6d66bb Compare May 20, 2024 15:02
@TomWoodward TomWoodward temporarily deployed to rex-web-make-group-for--lch4fv May 20, 2024 15:02 Inactive
@RoyEJohnson RoyEJohnson force-pushed the make-group-for-dropdown-checkboxes branch from 69cbcb1 to 0ccd721 Compare July 15, 2024 18:29
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-make-group-for--top9qn July 17, 2024 15:49 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-make-group-for--top9qn July 18, 2024 12:51 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-make-group-for--top9qn July 18, 2024 15:08 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-make-group-for--top9qn July 18, 2024 15:48 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-make-group-for--uzgbwn July 25, 2024 17:28 Inactive
@Malar-Natarajan Malar-Natarajan merged commit 4c6396b into main Jul 25, 2024
8 of 9 checks passed
@Malar-Natarajan Malar-Natarajan deleted the make-group-for-dropdown-checkboxes branch July 25, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
in-production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RoyEJohnson @Malar-Natarajan @jivey @TomWoodward @staxbot