Port components to ts 2 #2710
Merged
Port components to ts 2 #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
port-components-to-ts-2
branch
from
c36f86b to
c7dec46
Compare
RoyEJohnson
commented
Feb 26, 2025
| aria-label="close" | ||
| > | ||
| × | ||
| </button> | ||
| ); | ||
| } | ||
|
|
||
| export function FooterDialog({isOpen, title, children, className}) { |
There was a problem hiding this comment.
Not used anymore!
RoyEJohnson
commented
Feb 26, 2025
| import cn from 'classnames'; | ||
| import './form-elements.scss'; | ||
|
|
||
| export function StyledCheckbox({name, value, checked, onClick, forwardRef}) { |
There was a problem hiding this comment.
Nothing uses these anymore.
RoyEJohnson
commented
Feb 26, 2025
| @@ -74,6 +74,7 @@ global.fetch = jest.fn().mockImplementation((...args) => { | |||
| const isInstitutionalPartnership = (/pages\/institutional-partners/).test(args[0]); | |||
| const isKinetic = args[0].endsWith('kinetic/'); | |||
| const isHomepage = (/openstax-homepage/).test(args[0]); | |||
| const isImage = args[0].includes('/api/images/'); | |||
There was a problem hiding this comment.
Tests were noisy because the image paths weren't recognized properly
RoyEJohnson
commented
Feb 26, 2025
| @@ -4,6 +4,12 @@ import './helpers/mock-lazyload'; | |||
| import {LocalStorage} from 'node-localstorage'; | |||
| import ReactModal from 'react-modal'; | |||
|
|
|||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
This needs to be set in a bunch of tests the way it is in renewal-form.test.
jivey
approved these changes
Mar 4, 2025
RoyEJohnson
force-pushed
the
port-components-to-ts-2
branch
from
c7dec46 to
63be871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-734
Most of the files came through as renames, so you can see the changes in "Files changed".
For form-checkboxgroup and form-elements, you may want to look at the individual commits to see the post-rename changes.