CORE-671 CookieYes #2703
CORE-671 CookieYes #2703
Conversation
|
Tested on dev.openstax.org and it seems to work just fine. |
src/index.html
Outdated
| } else { | ||
| Sentry.captureMessage(`Failed to save cookie consent (HTTP status code: ${response.status})`); | ||
| } | ||
| }, (error) => Sentry.captureException(error) |
There was a problem hiding this comment.
i'm pretty sure these sentry calls are the ones triggering the "undefined variable sentry" errors
There was a problem hiding this comment.
Good point, I guess I should add a guard and ignore the errors otherwise? I think Sentry is not guaranteed to be accessible when GTM scripts run either.
src/index.html
Outdated
| <link rel="stylesheet" href="https://ram.openstax.org/osano/osano.css"> | ||
| <script src="https://cmp.osano.com/AzZqbXTbzhHsU3cv1/68d8e8ae-4024-4489-a000-72766ad284a6/osano.js"></script> | ||
| <script> | ||
| fetch('/accounts/api/user', { credentials: 'include' }).then((userResponse) => { |
There was a problem hiding this comment.
osweb also fetches the user, is this gonna make it fetch the user twice on every page load?
There was a problem hiding this comment.
Yes... I can have both this and the app code write the user to the window (only if not already present), I suppose
…able to prevent multiple loads
…the cached load function
| } | ||
|
|
||
| document.body.classList.add('hide-osano'); | ||
| function CookieYesToggle() { |
There was a problem hiding this comment.
I should move this to ui-components and use it in Rex
There was a problem hiding this comment.
It wasn't done in a shared way before because Roy didn't want to add styled components to osweb
You could pretty much copy/paste though. Maybe rex and assignable could share a component
|
This should be ready for another look |
Co-authored-by: Roy Johnson <roy.e.johnson@rice.edu>
Co-authored-by: Roy Johnson <roy.e.johnson@rice.edu>
Tom wants to move this snippet into GTM, so he requested that it be able to run without app code.