Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabbable option to Highlight object #76

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add tabbable option to Highlight object #76

wants to merge 6 commits into from

Conversation

RoyEJohnson
Copy link

@RoyEJohnson RoyEJohnson force-pushed the add-tabbable-option branch 3 times, most recently from 109c805 to fdc33f5 Compare January 31, 2024 23:26
TomWoodward
TomWoodward requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't commit the dist folder

@RoyEJohnson RoyEJohnson force-pushed the add-tabbable-option branch 2 times, most recently from e229050 to b4f8af0 Compare February 1, 2024 16:40
TomWoodward
TomWoodward requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update one of the injectHighlightWrappers specs to test adding the tabindex

otherwise this looks fine

@RoyEJohnson RoyEJohnson force-pushed the add-tabbable-option branch from c66c14c to 7cb7c70 Compare March 19, 2024 21:49
@RoyEJohnson RoyEJohnson force-pushed the add-tabbable-option branch from 7cb7c70 to a9037c3 Compare March 19, 2024 21:53
@RoyEJohnson RoyEJohnson force-pushed the add-tabbable-option branch from a9037c3 to bd17f1e Compare March 19, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWoodward TomWoodward TomWoodward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyEJohnson @TomWoodward