Code

Use mark instead of span#75

Code

Closed

RoyEJohnson wants to merge 16 commits intomainopenstax/highlighter:mainfrom use-mark-instead-of-spanopenstax/highlighter:use-mark-instead-of-spanCopy head branch name to clipboard

Commits

Commits on Nov 20, 2023

• Replace span with mark

  RoyEJohnson

  committed
  7af5df5

  Copy full SHA for 7af5df5

Commits on Feb 9, 2024

• Add aria-current to focused highlights

  RoyEJohnson

  committed
  a8f9bb6

  Copy full SHA for a8f9bb6

Commits on Mar 20, 2024

• Add tabbable option to Highlight object

  Show description for bd9a4be
  RoyEJohnson

  committed
  bd9a4be

  Copy full SHA for bd9a4be

• Include test with tabbable=true

  RoyEJohnson

  committed
  f051cbb

  Copy full SHA for f051cbb

• Use and update start-selected marker

  Show description for 6537821
  RoyEJohnson

  committed
  6537821

  Copy full SHA for 6537821

• Update spec to use mark

  RoyEJohnson

  committed
  b060ae8

  Copy full SHA for b060ae8

• Use text content instead of aria-label for begin/end spans

  Show description for 4f7c077
  RoyEJohnson

  committed
  4f7c077

  Copy full SHA for 4f7c077

• Use classes to indicate language and position of screenreader markers

  RoyEJohnson

  committed
  4296d75

  Copy full SHA for 4296d75

Commits on Mar 22, 2024

• Use data-startMessage as start marker

  RoyEJohnson

  committed
  4f61498

  Copy full SHA for 4f61498

Commits on Apr 15, 2024

• Put tabIndex back in for tabbable entries

  RoyEJohnson

  committed
  16cb18f

  Copy full SHA for 16cb18f

• Fix highlight.focus

  RoyEJohnson

  committed
  7869c30

  Copy full SHA for 7869c30

Commits on Apr 16, 2024

• remove screenreader nodes

  RoyEJohnson

  committed
  a3f650d

  Copy full SHA for a3f650d

• Adjust tests

  Show description for fcb95c9
  RoyEJohnson

  committed
  fcb95c9

  Copy full SHA for fcb95c9

Commits on May 17, 2024

• only first highlight is tabbable

  RoyEJohnson

  committed
  6384d5f

  Copy full SHA for 6384d5f

• Remove aria-current; use start-message to find currently selected

  RoyEJohnson

  committed
  3f9d7a0

  Copy full SHA for 3f9d7a0

• use .focus again

  RoyEJohnson

  committed
  676f94e

  Copy full SHA for 676f94e