Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check profile complete and SheerID response in setting lead FV status #1223

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

mwvolo
Copy link
Member

@mwvolo mwvolo commented Jan 18, 2024

The command to create the lead was overwriting the faculty status set by SheerID. Checking to make sure it's not one of the 3 expected values to come from SheerID before changing to incomplete_signup.

@mwvolo mwvolo requested a review from Dantemss January 18, 2024 21:00
@mwvolo mwvolo changed the title don't change to incomplete_signup if sheerid response Check profile complete and SheerID response in setting lead FV status Jan 19, 2024
@mwvolo
Copy link
Member Author

mwvolo commented Jan 22, 2024

@Dantemss found a different way that I think will work best to determine the faculty status we want to get to Salesforce - thank you for the feedback on the includes statement though!

When you get a moment, can you give this a review?

@mwvolo mwvolo merged commit 242d9e0 into main Jan 22, 2024
6 checks passed
@mwvolo mwvolo deleted the not-incomplete-if-sheerid branch January 22, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants