[bobcat] ObjectRetrierWraps fixes (cherry-pick #1234) #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ajkavanagh
commented
Jul 2, 2024
ajkavanagh
commented
- Add ObjectRetrier to CinderaBackupTests
- Add additional debug for ObjectRetrier
- Re-enable test 410 for cinder backups
- Fix ObjectRetrierWraps recursive wrapping
- Double Cinder backup restore time
- Add more retries to allow manila backup restore to complete
- Reduce ObjectRetrierWraps logging noise during normal use
- Modify test code to be less brittle
This fixes a race when checking if object ring is synced. (cherry picked from commit 0598ecf)
Add tenacity retries around ring sync check [bobcat backport]
The nova service may not be quite ready after vault initialisation for the basic network configuration, so add a retrier wrapper around the client for every test to make sure that it retries. (cherry picked from commit def0148)
Add a retrier-wrap to the nova client for octavia tests
In designate bobcat the designate team re-organised the sql-alchemy code and this has resulted in the bug [1] that means that the default values for various zone creations are no longer used from the /etc/designate/designate.conf file. i.e. the defaults are fixed. Related-Bug: LP#2042944 (cherry picked from commit a365823)
…-to-LP2042944 [bobcat] Disable changing default_ttl test due to designate bug
For https://review.opendev.org/897549 (cherry picked from commit 912f33e)
Add test to check ceph keys (new)
(cherry picked from commit 0a88897)
[stable/bobcat] Adding fixing broken configuration test for mysql-router
Added general class for testing keystone audit middleware
functionality in charms. Tests correct rendering of
api-paste.ini file and allows charms without an api-paste.ini
file to skip the tests.
Example usage with charm Heat:
tests/tests.yaml
tests:
- zaza.openstack.charm_tests.audit.tests.KeystoneAuditMiddlewareTest
tests_options:
audit-middleware:
service: heat
(cherry picked from commit ff5cdf5)
[stable/bobcat] Add class for keystone audit middleware testing
This adds the auto-retrier to the cinder client to get past race hazards and other transient errors.
It wasn't capturing member variables on the wrapped object that would then be used to make the call; thus, wrap those. This also disables (temporarily) the long running cinder backup test deletion whilst checking whether retries are the problem.
This is to verify that the retries really do work.
In order to ensure that an object that contains other objects that are called (e.g. the VolumeManager object on the Cinder client object), the ObjectRetrierWraps class needs to more agressively wrap non builtin classes.
This accounts for slow ServerStack when using ceph in the model.
Due to slow 1GiB networking in ServerStack the restore often exceeds the retries. Increase them to enable the restore to succeed.
The test for log function against ObjectRetrierWraps class is too brittle to the number of log calls. This commit makes it less brittle.
freyes
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.