Add cinder tests for audit middleware #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freyes
previously requested changes
Apr 18, 2024
There was a problem hiding this comment.
When we implement functional tests (as this PR does), there are two things to have in place:
- In this z-o-t PR, please, include a link to the review.opendev.org change that's being used to test this change (see example ).
- In the change you are proposing in review.opendev.org use the
Func-Test-Prheader, more details at https://docs.openstack.org/charm-guide/latest/community/software-contrib/making-a-change.html#functional-test-changes
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Apr 24, 2024
This commit adds Keystone audit middleware API logging to the Cinder charm in versions Yoga and newer to allow users to configure their environment for CADF compliance. This feature can be enabled/disabled and is set to 'disabled' by default to avoid bloat in log files. The logging output is configured to /var/log/apache2/cinder_error.log. This commit builds on previous discussions: juju/charm-helpers#808. Related-Pr: juju/charm-helpers#893 func-test-pr: openstack-charmers/zaza-openstack-tests#1200 Closes-Bug: 1856555 Change-Id: Ia7dbd6af2305e92eaa9a65890644c4a324ab2c65
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 24, 2024
* Update charm-cinder from branch 'master'
to e25b5d38fbb0692e5fab6e7f562c974316d61abe
- Add keystone audit middleware API logging
This commit adds Keystone audit middleware API logging to the Cinder
charm in versions Yoga and newer to allow users to configure their
environment for CADF compliance. This feature can be enabled/disabled
and is set to 'disabled' by default to avoid bloat in log files.
The logging output is configured to /var/log/apache2/cinder_error.log.
This commit builds on previous discussions:
juju/charm-helpers#808.
Related-Pr: juju/charm-helpers#893
func-test-pr: openstack-charmers/zaza-openstack-tests#1200
Closes-Bug: 1856555
Change-Id: Ia7dbd6af2305e92eaa9a65890644c4a324ab2c65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two tests for the audit middleware feature being added to Cinder.