Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile LoadBalancer service on config-changed #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

javacruft
Copy link
Contributor

Ensure that the LoadBalancer service definition is updated/created on config-changed events.

This covers upgrade from previous versions of the charm which directly patched the Juju created service definition.

Ensure that the LoadBalancer service definition is updated/created
on config-changed events.

This covers upgrade from previous versions of the charm which
directly patched the Juju created service definition.
Copy link
Contributor

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment from hemanth specifically talks about upgrade hooks events:

As the service ports are not dynamic, loadbalancer need not be created/patched on upgrade-hook or update-status hook In case the service ports are modified, _reconcile_lb should run on upgrade-hook

Shouldn't we just hook the upgrade-hook and not config_changed if we're interested in upgrade charm events?

Copy link
Contributor

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, reconcile only updates k8s SVC, not relation data, therefore it won't handle any change in the loadbalancer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants